Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 3152007: Revert "FBTF: Allow forward declaration of classes passed to sync IPC messages." (Closed)

Created:
10 years, 4 months ago by Elliot Glaysher
Modified:
9 years, 7 months ago
Reviewers:
Miranda Callahan
CC:
chromium-reviews, jam, Paweł Hajdan Jr., ben+cc_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org
Base URL:
http://src.chromium.org/git/chromium.git
Visibility:
Public.

Description

Revert "FBTF: Allow forward declaration of classes passed to sync IPC messages." This reverts commit r55735. BUG=none TEST=none TBR=mirandac Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=55738

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+519 lines, -944 lines) Patch
M chrome/browser/renderer_host/resource_message_filter_win.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_common.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/render_messages.h View 3 chunks +50 lines, -7 lines 0 comments Download
M chrome/common/render_messages.cc View 1 chunk +0 lines, -63 lines 0 comments Download
M chrome/common/render_messages_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/common/webkit_param_traits.h View 3 chunks +99 lines, -19 lines 0 comments Download
D chrome/common/webkit_param_traits.cc View 1 chunk +0 lines, -131 lines 0 comments Download
M chrome/renderer/render_view.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M ipc/ipc_message_impl_macros.h View 10 chunks +116 lines, -486 lines 0 comments Download
M ipc/ipc_message_macros.h View 35 chunks +200 lines, -152 lines 0 comments Download
M ipc/ipc_message_utils.h View 4 chunks +54 lines, -63 lines 0 comments Download
M ipc/ipc_message_utils_impl.h View 1 chunk +0 lines, -13 lines 0 comments Download
M ipc/ipc_sync_channel_unittest.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Miranda Callahan
10 years, 4 months ago (2010-08-11 16:54:03 UTC) #1
lgtm.  sigh!

Powered by Google App Engine
This is Rietveld 408576698