Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 3151039: cros_workon: store cros_workon state outside of /build (Closed)

Created:
10 years, 4 months ago by Mandeep Singh Baines
Modified:
9 years, 7 months ago
Reviewers:
zbehan, anush
CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa
Visibility:
Public.

Description

cros_workon: store cros_workon state outside of /build This solves the problem of cros_workon list of packages being clobbered by a new setup_board. BUG=5641 TEST=Verified all cases work correctly. 1. Verified that a pre-existing list of workon packages continues to work. 2. Verified that the package.unmask symlink is created correctly. 3. Verified that a new package can be worked on. 4. Verified that an existing package continues to be worked on. Change-Id: I566ac898ac4f74bdd5beb532c1ef0f70d4c02cec

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fixed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -13 lines) Patch
M cros_workon View 1 4 chunks +21 lines, -13 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Mandeep Singh Baines
10 years, 4 months ago (2010-08-25 20:37:32 UTC) #1
zbehan
http://codereview.chromium.org/3151039/diff/1/2 File cros_workon (right): http://codereview.chromium.org/3151039/diff/1/2#newcode77 cros_workon:77: die "ln -s ${UNMASK_FILE} ${KEYWORDS_FILE}" Why not both to ...
10 years, 4 months ago (2010-08-25 23:56:28 UTC) #2
Mandeep Singh Baines
Fixed. PTAL. zbehan@chromium.org (zbehan@chromium.org) wrote: > > http://codereview.chromium.org/3151039/diff/1/2 > File cros_workon (right): > > http://codereview.chromium.org/3151039/diff/1/2#newcode77 ...
10 years, 4 months ago (2010-08-26 00:18:15 UTC) #3
zbehan
10 years, 4 months ago (2010-08-26 00:19:06 UTC) #4
I know it works either way, but I don't see why chain symlinking should be the
way. ;)

LGTM!

On 2010/08/26 00:18:15, Mandeep Singh Baines wrote:
> Fixed. PTAL.
> 
> mailto:zbehan@chromium.org (mailto:zbehan@chromium.org) wrote:
> > 
> > http://codereview.chromium.org/3151039/diff/1/2
> > File cros_workon (right):
> > 
> > http://codereview.chromium.org/3151039/diff/1/2#newcode77
> > cros_workon:77: die "ln -s ${UNMASK_FILE} ${KEYWORDS_FILE}"
> > Why not both to WORKON_FILE?
> > 
> 
> OK. Works either way but I've changed to WORKON_FILE.
> 
> > http://codereview.chromium.org/3151039/show
>

Powered by Google App Engine
This is Rietveld 408576698