Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 3151037: Change code contains function to allow a return address just after the last instruction (Closed)

Created:
10 years, 4 months ago by Søren Thygesen Gjesse
Modified:
9 years, 7 months ago
Reviewers:
Kasper Lund
CC:
v8-dev
Visibility:
Public.

Description

Change code contains function to allow a return address just after the last instruction Then patching the return sequence for debugger break at return a call is placed at the very end of the instruction stream causing the return address to be just after the actual instruction in the code object. Committed: http://code.google.com/p/v8/source/detail?r=5341

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M src/objects-inl.h View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/cctest.status View 1 chunk +4 lines, -0 lines 0 comments Download
M test/cctest/test-debug.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Søren Thygesen Gjesse
With this it will go to the 2.2 branch.
10 years, 4 months ago (2010-08-25 10:20:03 UTC) #1
Kasper Lund
LGTM, but didn't we have an issue on ARM too?
10 years, 4 months ago (2010-08-25 10:30:09 UTC) #2
Søren Thygesen Gjesse
The tests failing on ARM are due to the initial problem with the return address ...
10 years, 4 months ago (2010-08-25 11:29:18 UTC) #3
Kasper Lund
10 years, 4 months ago (2010-08-25 12:49:27 UTC) #4
LGTM.

Powered by Google App Engine
This is Rietveld 408576698