Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 3151032: Add unique_name test attr, fix UI active test selection, clean up test_list. (Closed)

Created:
10 years, 4 months ago by Tammo Spalink
Modified:
9 years, 7 months ago
Reviewers:
Hung-Te
CC:
chromium-os-reviews_chromium.org, sosa+cc_chromium.org, seano, ericli, petkov+cc_chromium.org
Base URL:
http://src.chromium.org/git/autotest.git
Visibility:
Public.

Description

Add unique_name test attr, fix UI active test selection, clean up test_list. Change-Id: I945157c8c51454ad0abc5d56c7aa6feab01893d8

Patch Set 1 #

Total comments: 2

Patch Set 2 : turns out my previous unique_name approach was too easy #

Total comments: 2

Patch Set 3 : sequences get unique_name too #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -55 lines) Patch
M client/bin/factory.py View 1 2 9 chunks +37 lines, -29 lines 0 comments Download
M client/bin/factory_ui View 1 1 chunk +3 lines, -1 line 0 comments Download
M client/site_tests/suite_Factory/test_list View 1 2 7 chunks +52 lines, -25 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Tammo Spalink
10 years, 4 months ago (2010-08-24 06:48:17 UTC) #1
Hung-Te
http://codereview.chromium.org/3151032/diff/1/2 File client/bin/factory.py (right): http://codereview.chromium.org/3151032/diff/1/2#newcode64 client/bin/factory.py:64: kbd_shortcut=None, subtest_list=[]): So Automated Sequence won't have unique names. ...
10 years, 4 months ago (2010-08-24 08:18:23 UTC) #2
Tammo Spalink
http://codereview.chromium.org/3151032/diff/1/2 File client/bin/factory.py (right): http://codereview.chromium.org/3151032/diff/1/2#newcode64 client/bin/factory.py:64: kbd_shortcut=None, subtest_list=[]): we don't yet, but sure if you ...
10 years, 4 months ago (2010-08-24 09:16:43 UTC) #3
Hung-Te
10 years, 4 months ago (2010-08-24 10:34:20 UTC) #4
LGTM

On 2010/08/24 09:16:43, Tammo Spalink wrote:
> we don't yet, but sure if you want them :-) 
  Well, I don't need it now, so it's OK.

> you mean, instead of the comments?  my thinking was that going through these
was
> probably annoying for our testing team, and that we would uncomment once there
> is a real test.
   sounds ok.
> 
> On 2010/08/24 08:18:23, Hung-Te wrote:
> > what about adding a parameter like "bypass=True" or "dummy=True"?

Powered by Google App Engine
This is Rietveld 408576698