Rename the title of the Chromium Preferences dialog.

Rename the title of the Chromium Preferences dialog.

The menu currently is Preferences, so the dialog title should be named Chromium Preferences to match with it.

BUG=53114
TEST=run chrome, click on "Preferences" menu item. See if the dialog title is "Chromium/Google Chrome Preferences".

Screenshot: http://imgur.com/vferP

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57282

[tfarina, 2010-08-24 06:01:38]

Hi Tony, could you review this to me?

See screenshot: http://imgur.com/vferP

Note: I still have to fix the linux_chromeos. I will fix that tomorrow night.

[Evan Martin, 2010-08-24 14:57:16]

I think you don't need to worry about ChromeOS ("options" is fine there)

http://codereview.chromium.org/3151031/diff/2002/6003
File chrome/browser/gtk/options/options_window_gtk.cc (right):

http://codereview.chromium.org/3151031/diff/2002/6003#newcode106
chrome/browser/gtk/options/options_window_gtk.cc:106:
UTF16ToUTF8(preferences).c_str());
I'm not sure this will work in some languages, where the word for preferences
should come first.  (Like "preferências de aplicação" maybe?)

[tony, 2010-08-24 17:27:43]

http://codereview.chromium.org/3151031/diff/2002/6003
File chrome/browser/gtk/options/options_window_gtk.cc (right):

http://codereview.chromium.org/3151031/diff/2002/6003#newcode106
chrome/browser/gtk/options/options_window_gtk.cc:106:
UTF16ToUTF8(preferences).c_str());
On 2010/08/24 14:57:17, Evan Martin wrote:
> I'm not sure this will work in some languages, where the word for preferences
> should come first.  (Like "preferências de aplicação" maybe?)

Yeah, this isn't correct.  We'll need to add a new entry to
generated_resources.grd and get this translated.  In some cases "Preferences"
probably needs to be conjugated.

[tfarina, 2010-08-24 18:08:44]

On 2010/08/24 14:57:16, Evan Martin wrote:
> I think you don't need to worry about ChromeOS ("options" is fine there)
> 
I meant the compilation failure :)

> http://codereview.chromium.org/3151031/diff/2002/6003
> File chrome/browser/gtk/options/options_window_gtk.cc (right):
> 
> http://codereview.chromium.org/3151031/diff/2002/6003#newcode106
> chrome/browser/gtk/options/options_window_gtk.cc:106:
> UTF16ToUTF8(preferences).c_str());
> I'm not sure this will work in some languages, where the word for preferences
> should come first.  (Like "preferências de aplicação" maybe?)

You are right, this won't work :(
In Portuguese this would be "Preferências do Chromium" or "Preferências do
Google Chrome".

[tfarina, 2010-08-24 18:11:59]

On 2010/08/24 17:27:43, tony wrote:
> http://codereview.chromium.org/3151031/diff/2002/6003
> File chrome/browser/gtk/options/options_window_gtk.cc (right):
> 
> http://codereview.chromium.org/3151031/diff/2002/6003#newcode106
> chrome/browser/gtk/options/options_window_gtk.cc:106:
> UTF16ToUTF8(preferences).c_str());
> On 2010/08/24 14:57:17, Evan Martin wrote:
> > I'm not sure this will work in some languages, where the word for
preferences
> > should come first.  (Like "preferências de aplicação" maybe?)
> 
> Yeah, this isn't correct.  We'll need to add a new entry to
> generated_resources.grd and get this translated.  In some cases "Preferences"
> probably needs to be conjugated.

This means that we will not need to get "Preferences" from gtk stock, right? We
will add just a variance of the current IDS_OPTIONS_DIALOG_TITLE, like
IDS_PREFERENCES_DIALOG_TITLE?

[tony, 2010-08-24 18:14:37]

On 2010/08/24 18:11:59, tfarina wrote:
> This means that we will not need to get "Preferences" from gtk stock, right?
We
> will add just a variance of the current IDS_OPTIONS_DIALOG_TITLE, like
> IDS_PREFERENCES_DIALOG_TITLE?

Yes, that's right.

[Evan Martin, 2010-08-24 18:29:27]

We might be able to use the Mac resource for this.

Another option: something like
  "AppName -- Preferences"

[tony, 2010-08-24 18:31:50]

Mac doesn't have this resource, I think because sheets have no title.

I also considered Preferences -- Google Chrome, but strings are cheap and the
text is nicer as Google Chrome Preferences.  We might as well add a string.

On 2010/08/24 18:29:27, Evan Martin wrote:
> We might be able to use the Mac resource for this.
> 
> Another option: something like
>   "AppName -- Preferences"

[tfarina, 2010-08-24 19:48:09]

I made the change to the .grd file. Please take another look.

Note: I didn't test this yet, because I'm not at my linux box. I will test it
later tonight.

[tony, 2010-08-24 20:11:05]

LGTM

[tfarina, 2010-08-25 02:45:21]

On 2010/08/24 20:11:05, tony wrote:
> LGTM
Tested locally and sent to the trybots. For some reason the results didn't show
up here.
http://build.chromium.org/buildbot/try-server/builders/linux/builds/43922
http://build.chromium.org/buildbot/try-server/builders/linux_view/builds/6439
http://build.chromium.org/buildbot/try-server/builders/linux_chromeos/builds/...