src/ia32/macro-assembler-ia32.cc - Issue 3151017: Make the Integer32 type info only cover the signed 32 bit integers....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/macro-assembler-ia32.cc

Issue 3151017: Make the Integer32 type info only cover the signed 32 bit integers.... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/

Patch Set: Created 10 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/ia32/macro-assembler-ia32.cc

===================================================================

--- src/ia32/macro-assembler-ia32.cc (revision 5269)

+++ src/ia32/macro-assembler-ia32.cc (working copy)

@@ -1549,12 +1549,10 @@

if (scratch.is(no_reg)) scratch = dst;

cvttsd2si(scratch, FieldOperand(source, HeapNumber::kValueOffset));

cmp(scratch, 0x80000000u);

- if (push_pop || dst.is(source)) {

+ if (push_pop) {

j(not_equal, &done);

- if (push_pop) {

- pop(dst);

- jmp(on_not_int32);

- }

+ pop(dst);

+ jmp(on_not_int32);

} else {

j(equal, on_not_int32);

}

« no previous file with comments | « src/ia32/codegen-ia32.cc ('k') | src/type-info.h » ('j') | no next file with comments »