Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(947)

Side by Side Diff: src/ia32/macro-assembler-ia32.cc

Issue 3151017: Make the Integer32 type info only cover the signed 32 bit integers.... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/codegen-ia32.cc ('k') | src/type-info.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2009 the V8 project authors. All rights reserved. 1 // Copyright 2006-2009 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1531 matching lines...) Expand 10 before | Expand all | Expand 10 after
1542 Label done; 1542 Label done;
1543 bool push_pop = (scratch.is(no_reg) && dst.is(source)); 1543 bool push_pop = (scratch.is(no_reg) && dst.is(source));
1544 ASSERT(!scratch.is(source)); 1544 ASSERT(!scratch.is(source));
1545 if (push_pop) { 1545 if (push_pop) {
1546 push(dst); 1546 push(dst);
1547 scratch = dst; 1547 scratch = dst;
1548 } 1548 }
1549 if (scratch.is(no_reg)) scratch = dst; 1549 if (scratch.is(no_reg)) scratch = dst;
1550 cvttsd2si(scratch, FieldOperand(source, HeapNumber::kValueOffset)); 1550 cvttsd2si(scratch, FieldOperand(source, HeapNumber::kValueOffset));
1551 cmp(scratch, 0x80000000u); 1551 cmp(scratch, 0x80000000u);
1552 if (push_pop || dst.is(source)) { 1552 if (push_pop) {
1553 j(not_equal, &done); 1553 j(not_equal, &done);
1554 if (push_pop) { 1554 pop(dst);
1555 pop(dst); 1555 jmp(on_not_int32);
1556 jmp(on_not_int32);
1557 }
1558 } else { 1556 } else {
1559 j(equal, on_not_int32); 1557 j(equal, on_not_int32);
1560 } 1558 }
1561 1559
1562 bind(&done); 1560 bind(&done);
1563 if (push_pop) { 1561 if (push_pop) {
1564 add(Operand(esp), Immediate(kPointerSize)); // Pop. 1562 add(Operand(esp), Immediate(kPointerSize)); // Pop.
1565 } 1563 }
1566 if (!scratch.is(dst)) { 1564 if (!scratch.is(dst)) {
1567 mov(dst, scratch); 1565 mov(dst, scratch);
(...skipping 103 matching lines...) Expand 10 before | Expand all | Expand 10 after
1671 1669
1672 // Check that the code was patched as expected. 1670 // Check that the code was patched as expected.
1673 ASSERT(masm_.pc_ == address_ + size_); 1671 ASSERT(masm_.pc_ == address_ + size_);
1674 ASSERT(masm_.reloc_info_writer.pos() == address_ + size_ + Assembler::kGap); 1672 ASSERT(masm_.reloc_info_writer.pos() == address_ + size_ + Assembler::kGap);
1675 } 1673 }
1676 1674
1677 1675
1678 } } // namespace v8::internal 1676 } } // namespace v8::internal
1679 1677
1680 #endif // V8_TARGET_ARCH_IA32 1678 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/ia32/codegen-ia32.cc ('k') | src/type-info.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698