Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 3151017: Make the Integer32 type info only cover the signed 32 bit integers.... (Closed)

Created:
10 years, 4 months ago by Erik Corry
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Make the Integer32 type info only cover the signed 32 bit integers. Fix some bit op bugs introduced last week on IA32: http://code.google.com/p/chromium/issues/detail?id=52096 Committed: http://code.google.com/p/v8/source/detail?r=5273

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -21 lines) Patch
M src/arm/codegen-arm.cc View 1 chunk +15 lines, -1 line 0 comments Download
M src/ia32/codegen-ia32.cc View 4 chunks +7 lines, -5 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M src/type-info.h View 2 chunks +6 lines, -10 lines 0 comments Download
A test/mjsunit/bitops-info.js View 1 chunk +77 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Erik Corry
10 years, 4 months ago (2010-08-16 13:51:33 UTC) #1
Mads Ager (chromium)
10 years, 4 months ago (2010-08-16 14:17:03 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698