Issue 315013: Fix painting issue in Reader 9.2....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 315013: Fix painting issue in Reader 9.2.... (Closed)

Created:
11 years, 2 months ago by jam

Modified:
9 years, 7 months ago

Reviewers:
ananta

CC:
chromium-reviews_googlegroups.com, darin (slow to review)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fix painting issue in Reader 9.2. I don't know exactly what the cause of the bug is. But through experimentation I found that the plugin starts painting after the second NPP_Setwindow call. BUG=24883 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29805

Patch Set 1 #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	webkit/glue/plugins/webplugin_delegate_impl_win.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ananta

LGTM. Just curious to know whether Safari on Windows also has this problem.

11 years, 2 months ago (2009-10-22 19:28:57 UTC) #2

jam

11 years, 2 months ago (2009-10-22 19:34:42 UTC) #3

Safari and Firefox is fine, because they call NPP_SetWindow all the time
without any changes.  Opera and us only call it when things
_actually_change, and this new version seems to ignore the first call which
is why we're running into this issue.

On Thu, Oct 22, 2009 at 12:28 PM, <ananta@chromium.org> wrote:

> LGTM. Just curious to know whether Safari on Windows also has this problem.
>
>
>
> http://codereview.chromium.org/315013
>

Expand Messages | Collapse Messages