Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 315004: Added a case to build_config.h to cover compiling for Linux with 16-bit wchar... (Closed)

Created:
11 years, 2 months ago by Matthew Steele
Modified:
9 years, 7 months ago
Reviewers:
Mark Mentovai, tony, brettw
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Added a case to build_config.h to cover compiling for Linux with 16-bit wchars (alongside the existing cases for Windows with 16-bit wchars and Linux with 32-bit wchars) so that it becomes possible to compile and link the Chromium base together with third-party libraries that require short wchars. BUG=none TEST=none

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M build/build_config.h View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Matthew Steele
A small addition to build_config.h to make it possible to build on Linux with 16-bit ...
11 years, 2 months ago (2009-10-21 19:18:00 UTC) #1
tony
FWIW, I think this is a bad idea. Is it possible to recompile the third ...
11 years, 2 months ago (2009-10-21 20:22:16 UTC) #2
Mark Mentovai
Wow, bad. This will put us in a really bad situation: we'll work with the ...
11 years, 2 months ago (2009-10-21 20:24:39 UTC) #3
brettw
This is for another team using base, not changing the Chrome build. The other team ...
11 years, 2 months ago (2009-10-21 22:29:27 UTC) #4
Mark Mentovai
LGTM in that case. My fear is that someone will find this and try to ...
11 years, 2 months ago (2009-10-21 22:39:20 UTC) #5
brettw
11 years, 2 months ago (2009-10-22 18:04:46 UTC) #6
Checked in as r29786. I added a warning that this mode isn't necessarily
supported for all projects.

Powered by Google App Engine
This is Rietveld 408576698