Issue 3150033: Fail rather than crash if username+password are unspecified for NTLM on Linux+OSX.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3150033: Fail rather than crash if username+password are unspecified for NTLM on Linux+OSX. (Closed)

Created:
10 years, 4 months ago by cbentzel

Modified:
9 years, 7 months ago

Reviewers:
wtc

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org

Visibility:
Public.

Description

Fail rather than crash if username+password are unspecified for NTLM on Linux+OSX. This will be yanked out, but is being used to triage a bug. BUG=50517 TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57211

Patch Set 1 #

Total comments: 1

Patch Set 2 : Using MISSING_AUTH_CREDENTIALS #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
	M	net/http/http_auth_handler_ntlm.cc	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

wtc

LGTM. http://codereview.chromium.org/3150033/diff/1/2 File net/base/net_error_list.h (right): http://codereview.chromium.org/3150033/diff/1/2#newcode363 net/base/net_error_list.h:363: NET_ERROR(NTLM_AUTH_MISSING_USERNAME_PASSWORD, -342) Nit: I would replace USERNAME_PASSWORD by ...

10 years, 4 months ago (2010-08-24 17:01:36 UTC) #2

cbentzel

10 years, 4 months ago (2010-08-24 17:23:26 UTC) #3

MISSING_AUTH_CREDENTIALS should be sufficient. I'll change to that and land.

Expand Messages | Collapse Messages