Temporarily work around GPU process crash on Mac OS X.

Temporarily work around GPU process crash on Mac OS X.

BUG=52957
TEST=none (ran 3D CSS demos with --enable-accelerated-compositing)


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57130

[Ken Russell (switch to Gerrit), 2010-08-23 23:36:40]

Please review. Thanks.

[Nico, 2010-08-23 23:45:44]

temporarily LGTM.

have you cc'd rlp or informed him of this otherwise?

[rlp, 2010-08-23 23:46:16]

I'd rather fix this by commenting out the mac code temporarily as this will
also stop information from windows. I can get a fix for this now.

- Rachel

On Mon, Aug 23, 2010 at 4:36 PM, <kbr@chromium.org> wrote:

> Reviewers: Nico,
>
> Message:
> Please review. Thanks.
>
>
> Description:
> Temporarily work around GPU process crash on Mac OS X.
>
> BUG=52957
> TEST=none
>
>
> Please review this at http://codereview.chromium.org/3150030/show
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
>  M     chrome/gpu/gpu_thread.cc
>
>
> Index: chrome/gpu/gpu_thread.cc
> ===================================================================
> --- chrome/gpu/gpu_thread.cc    (revision 57118)
> +++ chrome/gpu/gpu_thread.cc    (working copy)
> @@ -122,8 +122,11 @@
>   }
>
>   GPUInfo gpu_info;
> -  gpu_info_collector::CollectGraphicsInfo(gpu_info);
>
> +  // TODO(rlp): this is crashing on Mac OS X because no OpenGL context
> +  // is current at this point.
> +  // gpu_info_collector::CollectGraphicsInfo(gpu_info);
> +
>   Send(new GpuHostMsg_ChannelEstablished(channel_handle, gpu_info));
>  }
>
>
>
>

[Nico, 2010-08-23 23:54:21]

I think it's better to uncomment this on all 3 platforms until there's
a fix that works on all 3 platforms. Else it's hard for the ports to
keep up.

On Mon, Aug 23, 2010 at 4:45 PM, Rachel Weinstein Petterson
<rlp@google.com> wrote:
> I'd rather fix this by commenting out the mac code temporarily as this will
> also stop information from windows. I can get a fix for this now.
> - Rachel
>
> On Mon, Aug 23, 2010 at 4:36 PM, <kbr@chromium.org> wrote:
>>
>> Reviewers: Nico,
>>
>> Message:
>> Please review. Thanks.
>>
>>
>> Description:
>> Temporarily work around GPU process crash on Mac OS X.
>>
>> BUG=52957
>> TEST=none
>>
>>
>> Please review this at http://codereview.chromium.org/3150030/show
>>
>> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>>
>> Affected files:
>>  M     chrome/gpu/gpu_thread.cc
>>
>>
>> Index: chrome/gpu/gpu_thread.cc
>> ===================================================================
>> --- chrome/gpu/gpu_thread.cc    (revision 57118)
>> +++ chrome/gpu/gpu_thread.cc    (working copy)
>> @@ -122,8 +122,11 @@
>>   }
>>
>>   GPUInfo gpu_info;
>> -  gpu_info_collector::CollectGraphicsInfo(gpu_info);
>>
>> +  // TODO(rlp): this is crashing on Mac OS X because no OpenGL context
>> +  // is current at this point.
>> +  // gpu_info_collector::CollectGraphicsInfo(gpu_info);
>> +
>>   Send(new GpuHostMsg_ChannelEstablished(channel_handle, gpu_info));
>>  }
>>
>>
>>
>
>

[rlp, 2010-08-24 00:03:27]

This doesn't exist for linux yet (my current project) so it's already
commented out there. This was first time mac was checked in. Given that most
of our users are windows users, we'd be losing a lot of data and we're at
the stages of trying to figure out if we're even collecting. Maf says he can
get a fix for this in the next day or so, so I'm fine keeping it commented
out until then. But I'd like to make sure we keep the windows one sending us
information for M7, even if the linux version doesn't make it into M7.

- Rachel

On Mon, Aug 23, 2010 at 4:54 PM, Nico Weber <thakis@chromium.org> wrote:

> I think it's better to uncomment this on all 3 platforms until there's
> a fix that works on all 3 platforms. Else it's hard for the ports to
> keep up.
>
> On Mon, Aug 23, 2010 at 4:45 PM, Rachel Weinstein Petterson
> <rlp@google.com> wrote:
> > I'd rather fix this by commenting out the mac code temporarily as this
> will
> > also stop information from windows. I can get a fix for this now.
> > - Rachel
> >
> > On Mon, Aug 23, 2010 at 4:36 PM, <kbr@chromium.org> wrote:
> >>
> >> Reviewers: Nico,
> >>
> >> Message:
> >> Please review. Thanks.
> >>
> >>
> >> Description:
> >> Temporarily work around GPU process crash on Mac OS X.
> >>
> >> BUG=52957
> >> TEST=none
> >>
> >>
> >> Please review this at http://codereview.chromium.org/3150030/show
> >>
> >> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
> >>
> >> Affected files:
> >>  M     chrome/gpu/gpu_thread.cc
> >>
> >>
> >> Index: chrome/gpu/gpu_thread.cc
> >> ===================================================================
> >> --- chrome/gpu/gpu_thread.cc    (revision 57118)
> >> +++ chrome/gpu/gpu_thread.cc    (working copy)
> >> @@ -122,8 +122,11 @@
> >>   }
> >>
> >>   GPUInfo gpu_info;
> >> -  gpu_info_collector::CollectGraphicsInfo(gpu_info);
> >>
> >> +  // TODO(rlp): this is crashing on Mac OS X because no OpenGL context
> >> +  // is current at this point.
> >> +  // gpu_info_collector::CollectGraphicsInfo(gpu_info);
> >> +
> >>   Send(new GpuHostMsg_ChannelEstablished(channel_handle, gpu_info));
> >>  }
> >>
> >>
> >>
> >
> >
>

[Ken Russell (switch to Gerrit), 2010-08-24 00:41:24]

On 2010/08/23 23:46:16, rlp wrote:
> I'd rather fix this by commenting out the mac code temporarily as this will
> also stop information from windows. I can get a fix for this now.

OK. I've uploaded a revised patch which only disables the Mac port and verified
that the GPU process no longer crashes. Please review.

> - Rachel
> 
> On Mon, Aug 23, 2010 at 4:36 PM, <mailto:kbr@chromium.org> wrote:
> 
> > Reviewers: Nico,
> >
> > Message:
> > Please review. Thanks.
> >
> >
> > Description:
> > Temporarily work around GPU process crash on Mac OS X.
> >
> > BUG=52957
> > TEST=none
> >
> >
> > Please review this at http://codereview.chromium.org/3150030/show
> >
> > SVN Base: svn://svn.chromium.org/chrome/trunk/src/
> >
> > Affected files:
> >  M     chrome/gpu/gpu_thread.cc
> >
> >
> > Index: chrome/gpu/gpu_thread.cc
> > ===================================================================
> > --- chrome/gpu/gpu_thread.cc    (revision 57118)
> > +++ chrome/gpu/gpu_thread.cc    (working copy)
> > @@ -122,8 +122,11 @@
> >   }
> >
> >   GPUInfo gpu_info;
> > -  gpu_info_collector::CollectGraphicsInfo(gpu_info);
> >
> > +  // TODO(rlp): this is crashing on Mac OS X because no OpenGL context
> > +  // is current at this point.
> > +  // gpu_info_collector::CollectGraphicsInfo(gpu_info);
> > +
> >   Send(new GpuHostMsg_ChannelEstablished(channel_handle, gpu_info));
> >  }
> >
> >
> >
> >
>

[Ken Russell (switch to Gerrit), 2010-08-24 00:42:17]

Changing reviewer list. Please review. Thanks.

[rpetterson, 2010-08-24 00:44:12]

LGTM