Issue 3150027: Marked OmniboxApiTest.Basic and AutocompleteBrowserTest.Autocomplete flaky on...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3150027: Marked OmniboxApiTest.Basic and AutocompleteBrowserTest.Autocomplete flaky on... (Closed)

Created:
10 years, 4 months ago by zel

Modified:
9 years, 6 months ago

Reviewers:
ericli, oshima

CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, ben+cc_chromium.org, pam+watch_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Marked OmniboxApiTest.Basic and AutocompleteBrowserTest.Autocomplete flaky on ChromeOS. Both test fail consistently in autotest runs while manual run with --gfilter_test seems to be OK. BUG=52928, 52929 TEST=make sure these two test don't cause autotest to fail anymore Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=56952

Patch Set 1 #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -2 lines)			Patch
	M	chrome/browser/autocomplete/autocomplete_browsertest.cc	View		2 chunks	+10 lines, -1 line	0 comments	Download
	M	chrome/browser/extensions/extension_omnibox_apitest.cc	View		2 chunks	+9 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

oshima

10 years, 4 months ago (2010-08-21 00:03:53 UTC) #2

LGTM

I believe it's okay to TBR for this type of changes.

Expand Messages | Collapse Messages