Issue 3150026: Fixes for the default texture....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3150026: Fixes for the default texture.... (Closed)

Created:
10 years, 4 months ago by gman1

Modified:
9 years, 7 months ago

Reviewers:
apatrick, apatrick_chromium

CC:
chromium-reviews, apatrick_chromium, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Fixes for the default texture. Since we are simulating non-shared resources on top of shared resources we can't actually let contexts use texture 0 because they are all sharing it. Also, moved the black textures to the texture manager. TEST=unit tests and ran conformance tests BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57214

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+288 lines, -173 lines)			Patch
M	gpu/command_buffer/service/context_group.cc	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	gpu/command_buffer/service/context_group_unittest.cc	View	1 2 3	3 chunks	+4 lines, -59 lines	0 comments	Download
M	gpu/command_buffer/service/gles2_cmd_decoder.cc	View	1	6 chunks	+11 lines, -37 lines	0 comments	Download
M	gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc	View	1	2 chunks	+3 lines, -1 line	0 comments	Download
M	gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.h	View	1	2 chunks	+4 lines, -3 lines	0 comments	Download
M	gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc	View	1 2 3 4	5 chunks	+15 lines, -70 lines	0 comments	Download
A	gpu/command_buffer/service/test_helper.h	View	3	1 chunk	+40 lines, -0 lines	0 comments	Download
A	gpu/command_buffer/service/test_helper.cc	View	3	1 chunk	+129 lines, -0 lines	0 comments	Download
M	gpu/command_buffer/service/texture_manager.h	View	1	3 chunks	+14 lines, -0 lines	0 comments	Download
M	gpu/command_buffer/service/texture_manager.cc	View	1	2 chunks	+44 lines, -3 lines	0 comments	Download
M	gpu/command_buffer/service/texture_manager_unittest.cc	View	1 2 3	5 chunks	+18 lines, -0 lines	0 comments	Download
M	gpu/gpu.gyp	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages