Issue 3150001: o3d: Use nacl from o3d codesite

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3150001: o3d: Use nacl from o3d codesite (Closed)

Created:
10 years, 4 months ago by piman

Modified:
9 years, 7 months ago

Reviewers:
Vangelis Kokkevis

CC:
o3d-review_googlegroups.com

Visibility:
Public.

Description

o3d: Use nacl from o3d codesite Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=56221

Patch Set 1 #

Patch Set 2 : pull in more nacl stuff, now builds on win32 #

Patch Set 3 : . #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -3 lines)			Patch
	M	DEPS	View	1	2 chunks	+2 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Vangelis Kokkevis

There's a strange build error in the trybot but it doesn't look related to this ...

10 years, 4 months ago (2010-08-10 01:26:11 UTC) #2

piman

PTAL. The linux trybot still fails because of the missing host pkgs on the build ...

10 years, 4 months ago (2010-08-10 02:10:02 UTC) #3

Vangelis Kokkevis

10 years, 4 months ago (2010-08-13 23:42:23 UTC) #4

LGTM .  Linux trybot seems green as well now.

On 2010/08/10 02:10:02, piman wrote:
> PTAL.
> The linux trybot still fails because of the missing host pkgs on the build
> slave, but it passes locally.
> The mac trybot still passes
> The win32 trybot failed, but the nacl bits passed and it build the plugin. I
> think the failure is that java is not installed on the build slave

Expand Messages | Collapse Messages