chrome/browser/extensions/extension_tabs_module.cc - Issue 3149029: Remove TYPE_EXTENSION_APP. Experiment failed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_tabs_module.cc

Issue 3149029: Remove TYPE_EXTENSION_APP. Experiment failed. (Closed) Base URL: git://codf21.jail/chromium.git

Patch Set: restored change to tab_strip_model.h Created 10 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/extension_tabs_module.cc

diff --git a/chrome/browser/extensions/extension_tabs_module.cc b/chrome/browser/extensions/extension_tabs_module.cc

index b74d714532da47b6c7d6d57bae691bc71240f469..107561a652b8d695c4f8284ba63526b359661c37 100644

--- a/chrome/browser/extensions/extension_tabs_module.cc

+++ b/chrome/browser/extensions/extension_tabs_module.cc

@@ -1090,7 +1090,7 @@ static bool GetTabById(int tab_id, Profile* profile,

static std::string GetWindowTypeText(Browser::Type type) {

// Note: for app popups, we report "app".

- if ((type & Browser::TYPE_APP) != 0 || type == Browser::TYPE_EXTENSION_APP)

+ if ((type & Browser::TYPE_APP) != 0)

return keys::kWindowTypeValueApp;

if ((type & Browser::TYPE_POPUP) != 0)

return keys::kWindowTypeValuePopup;