Remove TYPE_EXTENSION_APP. Experiment failed.

chrome/browser/browser.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/browser.h"
 
 #if defined(OS_WIN)
 #include <shellapi.h>
 #include <windows.h>
 #endif  // OS_WIN
@@ skipping 153 matching lines @@
 }
 
 // Return true if a browser is an app window or panel hosting
 // extension |extension_app|, and running under |profile|.
 bool BrowserHostsExtensionApp(Browser* browser,
                               Profile* profile,
                               Extension* extension_app) {
   if (browser->profile() != profile)
      return false;
 
-  if (browser->type() != Browser::TYPE_EXTENSION_APP &&
-      browser->type() != Browser::TYPE_APP_PANEL)
+  if (browser->type() != Browser::TYPE_APP_PANEL)
     return false;
 
   if (browser->extension_app() != extension_app)
     return false;
 
   return true;
 }
 
 }  // namespace
 
@@ skipping 133 matching lines @@
 
 // static
 Browser* Browser::CreateForApp(const std::string& app_name,
                                Extension* extension,
                                Profile* profile,
                                bool is_panel) {
   Browser::Type type = TYPE_APP;
 
   if (is_panel)
     type = TYPE_APP_PANEL;
-  else if (extension)
-    type = TYPE_EXTENSION_APP;
 
   Browser* browser = new Browser(type, profile);
   browser->app_name_ = app_name;
   browser->extension_app_ = extension;
 
   if (extension) {
     gfx::Rect initial_pos(extension->launch_width(),
                           extension->launch_height());
     if (!initial_pos.IsEmpty())
       browser->set_override_bounds(initial_pos);
@@ skipping 828 matching lines @@
   // Chrome OS opens a FileBrowse pop up instead of using download shelf.
   // So FEATURE_DOWNLOADSHELF is only added for non-chromeos platforms.
   features |= FEATURE_DOWNLOADSHELF;
 #endif  // !defined(OS_CHROMEOS)
 
   if (type() == TYPE_NORMAL) {
     features |= FEATURE_BOOKMARKBAR;
   }
 
   if (!hide_ui_for_fullscreen) {
-    if (type() != TYPE_NORMAL && type() != TYPE_EXTENSION_APP)
+    if (type() != TYPE_NORMAL)
       features |= FEATURE_TITLEBAR;
 
-    if (type() == TYPE_NORMAL || type() == TYPE_EXTENSION_APP)
+    if (type() == TYPE_NORMAL)
       features |= FEATURE_TABSTRIP;
 
-    if (type() == TYPE_NORMAL || type() == TYPE_EXTENSION_APP)
+    if (type() == TYPE_NORMAL)
       features |= FEATURE_TOOLBAR;
 
-    if (type() != TYPE_EXTENSION_APP && (type() & Browser::TYPE_APP) == 0)
+    if ((type() & Browser::TYPE_APP) == 0)
       features |= FEATURE_LOCATIONBAR;
   }
   return !!(features & feature);
 }
 
 bool Browser::IsClosingPermitted() {
   TabCloseableStateWatcher* watcher =
       g_browser_process->tab_closeable_state_watcher();
   bool can_close = !watcher || watcher->CanCloseBrowser(this);
   if (!can_close && is_attempting_to_close_browser_)
@@ skipping 1207 matching lines @@
       g_browser_process->tab_closeable_state_watcher();
   return !watcher || watcher->CanCloseTab(this);
 }
 
 void Browser::ToggleUseVerticalTabs() {
   use_vertical_tabs_.SetValue(!UseVerticalTabs());
   UseVerticalTabsChanged();
 }
 
 bool Browser::LargeIconsPermitted() const {
-  // We don't show the big icons in tabs for TYPE_EXTENSION_APP windows because
-  // for those windows, we already have a big icon in the top-left outside any
-  // tab. Having big tab icons too looks kinda redonk.
-  return TYPE_EXTENSION_APP != type();
+  return false;
 }
 
 ///////////////////////////////////////////////////////////////////////////////
 // Browser, TabStripModelObserver implementation:
 
 void Browser::TabInsertedAt(TabContents* contents,
                             int index,
                             bool foreground) {
   contents->set_delegate(this);
   contents->controller().SetWindowID(session_id());
@@ skipping 1620 matching lines @@
 }
 
 bool Browser::IsPinned(TabContents* source) {
   int index = tabstrip_model_.GetIndexOfTabContents(source);
   if (index == TabStripModel::kNoTab) {
     NOTREACHED() << "IsPinned called for tab not in our strip";
     return false;
   }
   return tabstrip_model_.IsTabPinned(index);
 }