Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(666)

Issue 3149025: dom-ui options: Remove special casing for Mac passwords, all platforms should... (Closed)

Created:
10 years, 4 months ago by csilv
Modified:
9 years, 7 months ago
Reviewers:
stuartmorgan, sargrass
CC:
chromium-reviews, ben+cc_chromium.org
Visibility:
Public.

Description

dom-ui options: Remove special casing for Mac passwords, all platforms should use the same UI. BUG=none TEST=Verify that the 'Show Passwords' button displays the passwords panel in dom-ui. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=56935

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : Rebase to r56875. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -12 lines) Patch
M chrome/browser/resources/options/personal_options.js View 1 2 3 1 chunk +5 lines, -12 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
csilv
+sargrass, +stuartmogran for review.
10 years, 4 months ago (2010-08-19 17:56:46 UTC) #1
csilv
On 2010/08/19 17:56:46, csilv wrote: > +stuartmogran for review. Whoops, sorry Stuart, lazy fingers.
10 years, 4 months ago (2010-08-19 17:57:25 UTC) #2
stuartmorgan
LGTM http://codereview.chromium.org/3149025/diff/1/2 File chrome/browser/resources/options/personal_options.js (right): http://codereview.chromium.org/3149025/diff/1/2#newcode52 chrome/browser/resources/options/personal_options.js:52: OptionsPage.showTab($('passwords-nav-tab')); Fix indentation.
10 years, 4 months ago (2010-08-19 18:02:43 UTC) #3
csilv
http://codereview.chromium.org/3149025/diff/1/2 File chrome/browser/resources/options/personal_options.js (right): http://codereview.chromium.org/3149025/diff/1/2#newcode52 chrome/browser/resources/options/personal_options.js:52: OptionsPage.showTab($('passwords-nav-tab')); On 2010/08/19 18:02:44, stuartmorgan wrote: > Fix indentation. ...
10 years, 4 months ago (2010-08-19 18:23:50 UTC) #4
sargrass
10 years, 4 months ago (2010-08-20 20:45:22 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld 408576698