Defines __gnu_linux__ and __linux__ are removed from the nacl-compiler.

Defines __gnu_linux__ and __linux__ are removed from the nacl-compiler.

[pasko-google - do not use, 2010-08-17 11:40:04]

LGTM

but, please, don't commit it now, the toolchain bots are red

[Mark Seaborn, 2010-08-20 15:54:41]

This seems to have broken the toolchain build, which is now failing with:

nacl64-g++ -o scons-out/nacl-x86-32/obj/tests/pepper_plugin/md5.o -c -O2
-fomit-frame-pointer -Wall -fdiagnostics-show-option -Werror -m32 -DXP_UNIX
-DNACL_STANDALONE=1 -I/b/slave/hardy32-toolchain_x86/build
-Itoolchain/linux_x86/nacl64/include/nacl tests/pepper_plugin/md5.cc
In file included from /b/slave/hardy32-toolchain_x86/build/base/port.h:9,
                 from /b/slave/hardy32-toolchain_x86/build/base/basictypes.h:12,
                 from tests/pepper_plugin/md5.cc:23:
/b/slave/hardy32-toolchain_x86/build/build/build_config.h:39:2: error: #error
Please add support for your platform in build/build_config.h
/b/slave/hardy32-toolchain_x86/build/build/build_config.h:119:2: error: #error
Please add support for your compiler in build/build_config.h

Given that fixing build_config.h involves changing another repository and
updating DEPS, and given that undefining __linux__ is not urgent (i.e. nothing
depends on it), I'd suggest it's better to revert this change for now.

Mark

[halyavin, 2010-08-22 07:59:43]

On 2010/08/20 15:54:41, Mark Seaborn wrote:
> This seems to have broken the toolchain build, which is now failing with:
> 
> nacl64-g++ -o scons-out/nacl-x86-32/obj/tests/pepper_plugin/md5.o -c -O2
> -fomit-frame-pointer -Wall -fdiagnostics-show-option -Werror -m32 -DXP_UNIX
> -DNACL_STANDALONE=1 -I/b/slave/hardy32-toolchain_x86/build
> -Itoolchain/linux_x86/nacl64/include/nacl tests/pepper_plugin/md5.cc
> In file included from /b/slave/hardy32-toolchain_x86/build/base/port.h:9,
>                  from
/b/slave/hardy32-toolchain_x86/build/base/basictypes.h:12,
>                  from tests/pepper_plugin/md5.cc:23:
> /b/slave/hardy32-toolchain_x86/build/build/build_config.h:39:2: error: #error
> Please add support for your platform in build/build_config.h
> /b/slave/hardy32-toolchain_x86/build/build/build_config.h:119:2: error: #error
> Please add support for your compiler in build/build_config.h
> 
> Given that fixing build_config.h involves changing another repository and
> updating DEPS, and given that undefining __linux__ is not urgent (i.e. nothing
> depends on it), I'd suggest it's better to revert this change for now.
> 
> Mark

Do you see -D__linux__ in site_scons/site_tools/naclsdk.py (see also
http://codereview.chromium.org/316200)?

[Mark Seaborn, 2010-08-22 09:30:17]

On 2010/08/22 07:59:43, halyavin wrote:
> On 2010/08/20 15:54:41, Mark Seaborn wrote:
> > This seems to have broken the toolchain build, which is now failing with:
> > 
> > nacl64-g++ -o scons-out/nacl-x86-32/obj/tests/pepper_plugin/md5.o -c -O2
> > -fomit-frame-pointer -Wall -fdiagnostics-show-option -Werror -m32 -DXP_UNIX
> > -DNACL_STANDALONE=1 -I/b/slave/hardy32-toolchain_x86/build
> > -Itoolchain/linux_x86/nacl64/include/nacl tests/pepper_plugin/md5.cc
> > In file included from /b/slave/hardy32-toolchain_x86/build/base/port.h:9,
> >                  from
> /b/slave/hardy32-toolchain_x86/build/base/basictypes.h:12,
> >                  from tests/pepper_plugin/md5.cc:23:
> > /b/slave/hardy32-toolchain_x86/build/build/build_config.h:39:2: error:
#error
> > Please add support for your platform in build/build_config.h
> > /b/slave/hardy32-toolchain_x86/build/build/build_config.h:119:2: error:
#error
> > Please add support for your compiler in build/build_config.h
> > 
> > Given that fixing build_config.h involves changing another repository and
> > updating DEPS, and given that undefining __linux__ is not urgent (i.e.
nothing
> > depends on it), I'd suggest it's better to revert this change for now.
> > 
> > Mark
> 
> Do you see -D__linux__ in site_scons/site_tools/naclsdk.py

Yes, but apparently that is not making it into the nacl-g++ invocation above.

> (see also
> http://codereview.chromium.org/316200%29?

That URL gives a 404 error.

Mark

[pasko-google - do not use, 2011-05-18 21:49:56]

http://codereview.chromium.org/3149014/diff/2001/gcc/gcc/config/i386/nacl.h
File gcc/gcc/config/i386/nacl.h (left):

http://codereview.chromium.org/3149014/diff/2001/gcc/gcc/config/i386/nacl.h#o...
gcc/gcc/config/i386/nacl.h:212: builtin_define ("__gnu_linux__");			\
btw, you should have removed the TODO above ...