Issue 3149001: Command-line utility to execute TPM commands bypassing the TSS stack.

Issue 3149001: Command-line utility to execute TPM commands bypassing the TSS stack. (Closed)

Created:
10 years, 4 months ago by Luigi Semenzato

Modified:
9 years, 7 months ago

Reviewers:
Randall Spangler, gauravsh

CC:
chromium-os-reviews_chromium.org, Randall Spangler, gauravsh, Bill Richardson, Luigi Semenzato

Base URL:
ssh://git@chromiumos-git/vboot_reference.git

Visibility:
Public.

Description

Command-line utility to execute TPM commands bypassing the TSS stack.

Patch Set 2 : Remove dead macros. #

Total comments: 2

Patch Set 4 : . #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+369 lines, -1 line)			Patch
A	firmware/lib/tpm_lite/include/tpm_error_messages.h	View	1 2	1 chunk	+250 lines, -0 lines	0 comments	Download
M	firmware/version.c	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	utility/Makefile	View	1 2 3	2 chunks	+4 lines, -0 lines	0 comments	Download
A	utility/tpmc.c	View	1 2	1 chunk	+114 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Luigi Semenzato

Here's the TPM command-line utility. Very basic, but should come in handy.

10 years, 4 months ago (2010-08-10 00:22:45 UTC) #1

gauravsh

lgtm with comment http://codereview.chromium.org/3149001/diff/2001/3001 File firmware/lib/tpm_lite/include/tpm_error_messages.h (right): http://codereview.chromium.org/3149001/diff/2001/3001#newcode113 firmware/lib/tpm_lite/include/tpm_error_messages.h:113: { "TPM_MA_TICKET_SIGNATURE", TPM_E_BASE + 92, "Migration ...

10 years, 4 months ago (2010-08-10 00:41:58 UTC) #2

Luigi Semenzato

10 years, 4 months ago (2010-08-10 16:28:14 UTC) #3

Fixed and pushing.  Thanks.

On 2010/08/10 00:41:58, gauravsh wrote:
> lgtm with comment
> 
> http://codereview.chromium.org/3149001/diff/2001/3001
> File firmware/lib/tpm_lite/include/tpm_error_messages.h (right):
> 
> http://codereview.chromium.org/3149001/diff/2001/3001#newcode113
> firmware/lib/tpm_lite/include/tpm_error_messages.h:113: {
> "TPM_MA_TICKET_SIGNATURE", TPM_E_BASE + 92, "Migration authority signature
> validation failure" },
> minor nit: these all need to be 80 chars. might make is easier to read too if
> you move the strings to the 2nd line.
> 
> http://codereview.chromium.org/3149001/diff/2001/3004
> File utility/tpmc.c (right):
> 
> http://codereview.chromium.org/3149001/diff/2001/3004#newcode84
> utility/tpmc.c:84: FOR_EACH_COMMAND(c) {
> In general, macros are discouraged. Particularly, in this case, they seem
> unnecessary and don't save much space.
> 
> You might want to consider removing them.

Expand Messages | Collapse Messages