Issue 3148033: Suppress invalid read under gpu_info_collector::CollectGraphicsInfo...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3148033: Suppress invalid read under gpu_info_collector::CollectGraphicsInfo... (Closed)

Created:
10 years, 4 months ago by Timur Iskhodzhanov

Modified:
9 years, 6 months ago

Reviewers:
Alexander Potapenko

CC:
chromium-reviews, Timur Iskhodzhanov, Alexander Potapenko, pam+watch_chromium.org, stuartmorgan+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Suppress invalid read under gpu_info_collector::CollectGraphicsInfo BUG=52957 TBR=glider Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=56994

Patch Set 1 #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -0 lines)			Patch
	M	tools/valgrind/memcheck/suppressions.txt	View		1 chunk	+10 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Alexander Potapenko

10 years, 4 months ago (2010-08-23 08:37:49 UTC) #2

LGTM

On Sat, Aug 21, 2010 at 6:47 PM,  <timurrrr@chromium.org> wrote:
> Reviewers: Alexander Potapenko,
>
> Description:
> Suppress invalid read under gpu_info_collector::CollectGraphicsInfo
> BUG=52957
> TBR=glider
>
> Please review this at http://codereview.chromium.org/3148033/show
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
>  M     tools/valgrind/memcheck/suppressions.txt
>
>
> Index: tools/valgrind/memcheck/suppressions.txt
> ===================================================================
> --- tools/valgrind/memcheck/suppressions.txt    (revision 56993)
> +++ tools/valgrind/memcheck/suppressions.txt    (working copy)
> @@ -4211,3 +4211,13 @@
>    fun:_ZN17ExtensionsService18UninstallExtensionERKSsb
>    fun:_ZN18AutomationProvider18UninstallExtensionEiPb
>  }
> +{
> +   bug_52957
> +   Memcheck:Addr4
> +   fun:glGetString
> +   fun:_ZN18gpu_info_collector19CollectGraphicsInfoER7GPUInfo
> +   fun:_ZN9GpuThread18OnEstablishChannelEi
> +   fun:_Z16DispatchToMethodI9GpuThreadMS0_FviEiEvPT_T0_RK6Tuple1IT1_E
> +
>
fun:_ZN3IPC16MessageWithTupleI6Tuple1IiEE8DispatchI9GpuThreadMS5_FviEEEbPKNS_7MessageEPT_T0_
> +   fun:_ZN9GpuThread24OnControlMessageReceivedERKN3IPC7MessageE
> +}
>
>
>

Expand Messages | Collapse Messages