Issue 3148024: Disabling DRT related initializations in unit-test mode, they...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3148024: Disabling DRT related initializations in unit-test mode, they... (Closed)

Created:
10 years, 4 months ago by Jay Civelli

Modified:
9 years, 7 months ago

Reviewers:
tkent

CC:
chromium-reviews, pam+watch_chromium.org, John Grabowski, darin-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Disabling DRT related initializations in unit-test mode. WebKit unit-tests using webkit_support fail with these initializations as the test executable doesn't have any packages. BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=56949

Patch Set 1 #

Patch Set 2 : '' #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -12 lines)			Patch
M	webkit/support/platform_support.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	webkit/support/platform_support_gtk.cc	View		1 chunk	+4 lines, -2 lines	0 comments	Download
M	webkit/support/platform_support_mac.mm	View		2 chunks	+5 lines, -2 lines	0 comments	Download
M	webkit/support/platform_support_win.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	webkit/support/webkit_support.cc	View	1	3 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages