Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 3148022: cros_extract_deps -j writes JSON, sorted by package name. (Closed)

Created:
10 years, 4 months ago by seano
Modified:
9 years, 7 months ago
Reviewers:
piman
CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa
Base URL:
ssh://gitrw.chromium.org/crosutils.git
Visibility:
Public.

Description

cros_extract_deps -j writes JSON, sorted by package name. Rationale: Consumers of this output should not have to eval() python code in order to use the output. Also potentially useful for dumping out of buildbot for consumption by other web-based tools.

Patch Set 1 #

Patch Set 2 : Make json default. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M cros_extract_deps View 1 3 chunks +10 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
seano
10 years, 4 months ago (2010-08-18 14:53:35 UTC) #1
piman
LGTM, though I think you can simply remove the option and always dump as json, ...
10 years, 4 months ago (2010-08-18 16:04:31 UTC) #2
seano
Thanks, I threw the option in there in case there were tools I was unaware ...
10 years, 4 months ago (2010-08-18 16:25:41 UTC) #3
seano
Made JSON output the default & Tested on my box. Submitting. On 2010/08/18 16:25:41, seano ...
10 years, 4 months ago (2010-08-18 16:45:41 UTC) #4
jimhebert
On Wed, Aug 18, 2010 at 9:04 AM, <piman@chromium.org> wrote: > LGTM, though I think ...
10 years, 4 months ago (2010-08-21 00:22:22 UTC) #5
jimhebert
10 years, 4 months ago (2010-08-21 00:43:30 UTC) #6
Bah, nevermind. PEBKAC. Withdrawn.

jim

On Fri, Aug 20, 2010 at 5:22 PM, Jim Hebert <jimhebert@chromium.org> wrote:

> On Wed, Aug 18, 2010 at 9:04 AM, <piman@chromium.org> wrote:
>
>> LGTM, though I think you can simply remove the option and always dump as
>> json,
>> since the output looks compatible with the input of the other tools.
>>
>
> Unfortunately, it's not.  Bug filed,
> http://code.google.com/p/chromium-os/issues/detail?id=5980
>

Powered by Google App Engine
This is Rietveld 408576698