Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(518)

Issue 3148006: Correctly auto-detect 2GHz and 5GHz phy devices (Closed)

Created:
10 years, 4 months ago by Paul Stewart
Modified:
9 years, 7 months ago
Reviewers:
Sam Leffler, ericli
CC:
chromium-os-reviews_chromium.org, sosa+cc_chromium.org, seano, ericli, petkov+cc_chromium.org
Base URL:
ssh://gitrw.chromium.org/autotest.git
Visibility:
Public.

Description

Correctly auto-detect 2GHz and 5GHz phy devices Fixed already existing code to parse "iw list" so that it can correctly detect the 5GHz and 2GHz radios on a linux router. Also, set the default ethernet interface to "eth0" since this is the default in our setups and "eth1" seems strange for a default. TEST=reran autotest with no phydevs specified BUG=none

Patch Set 1 #

Patch Set 2 : Changed comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -8 lines) Patch
M server/site_linux_router.py View 1 2 chunks +27 lines, -8 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Paul Stewart
10 years, 4 months ago (2010-08-11 19:56:19 UTC) #1
Sam Leffler
10 years, 4 months ago (2010-08-11 19:58:26 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698