Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 3148001: Reworked Avi's patch for master prefs implemented on mac to work with new fir... (Closed)

Created:
10 years, 4 months ago by Miranda Callahan
Modified:
9 years, 7 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, John Grabowski, pam+watch_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

Reworked Avi's patch for master prefs implemented on mac (http://codereview.chromium.org/2903014/show), so that it will work with new first run sequence on Windows and Mac. BUG=44901 TEST=in bug Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57099

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+299 lines, -343 lines) Patch
M chrome/browser/first_run/first_run.h View 1 2 3 2 chunks +13 lines, -1 line 0 comments Download
M chrome/browser/first_run/first_run.cc View 1 2 3 2 chunks +233 lines, -0 lines 0 comments Download
M chrome/browser/first_run/first_run_gtk.cc View 1 2 3 3 chunks +1 line, -88 lines 0 comments Download
M chrome/browser/first_run/first_run_mac.mm View 1 2 3 2 chunks +4 lines, -7 lines 0 comments Download
M chrome/browser/first_run/first_run_win.cc View 1 2 3 6 chunks +47 lines, -231 lines 0 comments Download
M chrome/chrome_installer_util.gypi View 1 2 3 2 chunks +1 line, -16 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Avi (use Gerrit)
http://codereview.chromium.org/3148001/diff/1/7 File chrome/chrome_installer_util.gypi (right): http://codereview.chromium.org/3148001/diff/1/7#newcode130 chrome/chrome_installer_util.gypi:130: ['OS=="linux" or OS=="freebsd" or OS=="openbsd" or OS=="mac"', { This ...
10 years, 4 months ago (2010-08-16 18:35:56 UTC) #1
Miranda Callahan
On 2010/08/16 18:35:56, Avi wrote: > http://codereview.chromium.org/3148001/diff/1/7 > File chrome/chrome_installer_util.gypi (right): > > http://codereview.chromium.org/3148001/diff/1/7#newcode130 > ...
10 years, 4 months ago (2010-08-16 18:40:35 UTC) #2
Miranda Callahan
Avi, this is ready for review. http://codereview.chromium.org/3148001/diff/1/7 File chrome/chrome_installer_util.gypi (right): http://codereview.chromium.org/3148001/diff/1/7#newcode130 chrome/chrome_installer_util.gypi:130: ['OS=="linux" or OS=="freebsd" ...
10 years, 4 months ago (2010-08-20 17:48:49 UTC) #3
Avi (use Gerrit)
10 years, 4 months ago (2010-08-20 18:35:38 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698