Issue 3146037: Cleanup the AST code by removing unused parts and get rid of the...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3146037: Cleanup the AST code by removing unused parts and get rid of the... (Closed)

Created:
10 years, 4 months ago by Kasper Lund

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Cleanup the AST code by removing unused parts and get rid of the flow graph code completely. Add new AST node for null compares and use it to make the full codegens better at generating code for null comparisons. Committed: http://code.google.com/p/v8/source/detail?r=5323

Patch Set 1 #

Total comments: 1

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+360 lines, -2293 lines)			Patch
M	src/SConscript	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/arm/codegen-arm.cc	View	2 chunks	+34 lines, -41 lines	0 comments	Download
M	src/arm/full-codegen-arm.cc	View	1 chunk	+30 lines, -0 lines	0 comments	Download
M	src/ast.h	View	47 chunks	+38 lines, -227 lines	0 comments	Download
M	src/ast.cc	View	5 chunks	+9 lines, -569 lines	0 comments	Download
M	src/ast-inl.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	src/compiler.cc	View	5 chunks	+4 lines, -43 lines	0 comments	Download
M	src/data-flow.h	View	4 chunks	+16 lines, -60 lines	0 comments	Download
M	src/data-flow.cc	View	6 chunks	+16 lines, -256 lines	0 comments	Download
D	src/flow-graph.h	View	1 chunk	+0 lines, -180 lines	0 comments	Download
D	src/flow-graph.cc	View	1 chunk	+0 lines, -763 lines	0 comments	Download
M	src/full-codegen.cc	View	2 chunks	+10 lines, -0 lines	0 comments	Download
M	src/ia32/codegen-ia32.cc	View	5 chunks	+41 lines, -41 lines	0 comments	Download
M	src/ia32/full-codegen-ia32.cc	View	1 chunk	+26 lines, -0 lines	0 comments	Download
M	src/parser.cc	View	13 chunks	+24 lines, -34 lines	0 comments	Download
M	src/prettyprinter.h	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	src/prettyprinter.cc	View	9 chunks	+30 lines, -20 lines	0 comments	Download
M	src/rewriter.cc	View	4 chunks	+13 lines, -2 lines	0 comments	Download
M	src/x64/codegen-x64.cc	View	5 chunks	+40 lines, -41 lines	0 comments	Download
M	src/x64/full-codegen-x64.cc	View	1 chunk	+27 lines, -0 lines	1 comment	Download
M	tools/gyp/v8.gyp	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	tools/visual_studio/v8_base.vcproj	View	1 chunk	+0 lines, -8 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

10 years, 4 months ago (2010-08-24 07:17:45 UTC) #2

STV!

http://codereview.chromium.org/3146037/diff/1/21
File src/x64/full-codegen-x64.cc (right):

http://codereview.chromium.org/3146037/diff/1/21#newcode3019
src/x64/full-codegen-x64.cc:3019: Label materialize_true, materialize_false;
Indentation.

Expand Messages | Collapse Messages