Issue 3146028: Widen an IPC sendmsg suppression and suppress invalid read in ~ChromeURLReque...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3146028: Widen an IPC sendmsg suppression and suppress invalid read in ~ChromeURLReque... (Closed)

Created:
10 years, 4 months ago by Timur Iskhodzhanov

Modified:
9 years, 6 months ago

Reviewers:
Alexander Potapenko

CC:
chromium-reviews, Timur Iskhodzhanov, Alexander Potapenko, pam+watch_chromium.org, stuartmorgan+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Widen an IPC sendmsg suppression and suppress invalid read in ~ChromeURLRequestContext BUG=52825, 20997 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=56830

Patch Set 1 #

Patch Set 2 : '' #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -0 lines)			Patch
	M	tools/valgrind/memcheck/suppressions.txt	View		2 chunks	+14 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Alexander Potapenko

10 years, 4 months ago (2010-08-20 09:28:24 UTC) #2

LGTM

On Fri, Aug 20, 2010 at 1:26 PM,  <timurrrr@chromium.org> wrote:
> Reviewers: Alexander Potapenko,
>
> Description:
> Widen an IPC sendmsg suppression and suppress invalid read in
> ~ChromeURLRequestContext
> BUG=52825,20997
>
> Please review this at http://codereview.chromium.org/3146028/show
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
>  M     tools/valgrind/memcheck/suppressions.txt
>
>
> Index: tools/valgrind/memcheck/suppressions.txt
> ===================================================================
> --- tools/valgrind/memcheck/suppressions.txt    (revision 56828)
> +++ tools/valgrind/memcheck/suppressions.txt    (working copy)
> @@ -1496,7 +1496,9 @@
>    Memcheck:Param
>    socketcall.sendmsg(msg.msg_iov[i])
>    fun:sendmsg$UNIX2003
> +   ...
>
>
 fun:_ZN4base19MessagePumpLibevent21FileDescriptorWatcher28OnFileCanReadWithoutBlockingEiPS0_
> +   ...
>    fun:event_process_active
>    fun:event_base_loop
>  }
> @@ -4134,3 +4136,15 @@
>    fun:_ZN10disk_cache10InFlightIO14InvokeCallbackEPNS_12BackgroundIOEb
>    fun:_ZN10disk_cache12BackgroundIO13OnIOSignalledEv
>  }
> +{
> +   bug_52825
> +   Memcheck:Addr4
> +
>
fun:_ZNKSt8_Rb_treeIjSt4pairIKjP12ObserverListI20NotificationObserverLb0EEESt10_Select1stIS6_ESt4lessIjESaIS6_EE8_M_beginEv
> +
>
fun:_ZNKSt8_Rb_treeIjSt4pairIKjP12ObserverListI20NotificationObserverLb0EEESt10_Select1stIS6_ESt4lessIjESaIS6_EE4findERS1_
> +
>
fun:_ZNKSt3mapIjP12ObserverListI20NotificationObserverLb0EESt4lessIjESaISt4pairIKjS3_EEE4findERS7_
> +
>
fun:_ZN19NotificationService6HasKeyERKSt3mapIjP12ObserverListI20NotificationObserverLb0EESt4lessIjESaISt4pairIKjS4_EEERK18NotificationSource
> +
>
fun:_ZN19NotificationService6NotifyE16NotificationTypeRK18NotificationSourceRK19NotificationDetails
> +   fun:_ZN23ChromeURLRequestContextD0Ev
> +   ...
> +   fun:_ZN17URLRequestHttpJobD0Ev
> +}
>
>
>

Expand Messages | Collapse Messages