Issue 3146024: Fix typo in setting event masks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3146024: Fix typo in setting event masks. (Closed)

Created:
10 years, 4 months ago by Peter Kasting

Modified:
9 years, 7 months ago

Reviewers:
Elliot Glaysher

CC:
chromium-reviews, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fix typo in setting event masks. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=56769

Patch Set 1 #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/browser/gtk/tabs/tab_gtk.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Peter Kasting

Would this bug have caused a visible effect (e.g. tabs not getting a highlight on ...

10 years, 4 months ago (2010-08-19 21:17:28 UTC) #1

Elliot Glaysher

10 years, 4 months ago (2010-08-19 21:39:56 UTC) #2

LGTM. I patched this into my tree and wasn't able to see a difference.

On Thu, Aug 19, 2010 at 2:17 PM,  <pkasting@chromium.org> wrote:
> Reviewers: Elliot Glaysher,
>
> Message:
> Would this bug have caused a visible effect (e.g. tabs not getting a
> highlight
> on mouseover)?  Should I merge to 472?
>
> Description:
> Fix typo in setting event masks.
>
> BUG=none
> TEST=none
>
> Please review this at http://codereview.chromium.org/3146024/show
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
>  M     chrome/browser/gtk/tabs/tab_gtk.cc
>
>
> Index: chrome/browser/gtk/tabs/tab_gtk.cc
> ===================================================================
> --- chrome/browser/gtk/tabs/tab_gtk.cc  (revision 56725)
> +++ chrome/browser/gtk/tabs/tab_gtk.cc  (working copy)
> @@ -152,7 +152,7 @@
>                    G_CALLBACK(OnLeaveNotifyEventThunk), this);
>   gtk_widget_add_events(event_box_,
>         GDK_BUTTON_PRESS_MASK | GDK_BUTTON_RELEASE_MASK |
> -        GDK_LEAVE_NOTIFY_MASK | GDK_LEAVE_NOTIFY_MASK);
> +        GDK_ENTER_NOTIFY_MASK | GDK_LEAVE_NOTIFY_MASK);
>   gtk_container_add(GTK_CONTAINER(event_box_), TabRendererGtk::widget());
>   gtk_widget_show_all(event_box_);
>  }
>
>
>

Expand Messages | Collapse Messages