Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issue 3146010: Add gclient_smoketest.py to PRESUBMIT.py check (Closed)

Created:
10 years, 4 months ago by M-A Ruel
Modified:
9 years, 7 months ago
Reviewers:
bradnelson, bradn
CC:
chromium-reviews, M-A Ruel
Visibility:
Public.

Description

Add gclient_smoketest.py to PRESUBMIT.py check It raises the time to run the presubmit to ~30 seconds but it's still worth. TEST=run more often Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=55759

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M PRESUBMIT.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
M-A Ruel
10 years, 4 months ago (2010-08-11 18:33:31 UTC) #1
bradn
10 years, 4 months ago (2010-08-11 18:35:13 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698