Issue 3146008: Change lazy compilation stub to a builtin....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3146008: Change lazy compilation stub to a builtin.... (Closed)

Created:
10 years, 4 months ago by Rico

Modified:
9 years, 6 months ago

Reviewers:
Kasper Lund

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Change lazy compilation stub to a builtin. This change changes the lazy compilation stub to a builtin and eliminates the argc (argument count for the function for which to create a lazy stub) parameter. Committed: http://code.google.com/p/v8/source/detail?r=5244

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+69 lines, -114 lines)			Patch
M	src/arm/builtins-arm.cc	View		1 chunk	+23 lines, -0 lines	0 comments	Download
M	src/arm/stub-cache-arm.cc	View		1 chunk	+0 lines, -32 lines	0 comments	Download
M	src/builtins.h	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	src/compiler.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/handles.h	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	src/handles.cc	View		1 chunk	+0 lines, -5 lines	0 comments	Download
M	src/heap.cc	View	1	1 chunk	+1 line, -2 lines	0 comments	Download
M	src/ia32/builtins-ia32.cc	View		1 chunk	+20 lines, -0 lines	0 comments	Download
M	src/ia32/stub-cache-ia32.cc	View		1 chunk	+0 lines, -24 lines	0 comments	Download
M	src/objects-inl.h	View		2 chunks	+2 lines, -3 lines	0 comments	Download
M	src/stub-cache.h	View		2 chunks	+0 lines, -3 lines	0 comments	Download
M	src/stub-cache.cc	View		1 chunk	+0 lines, -17 lines	0 comments	Download
M	src/x64/builtins-x64.cc	View		1 chunk	+20 lines, -0 lines	0 comments	Download
M	src/x64/stub-cache-x64.cc	View		1 chunk	+0 lines, -24 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Kasper Lund

LGTM! http://codereview.chromium.org/3146008/diff/1/8 File src/heap.cc (right): http://codereview.chromium.org/3146008/diff/1/8#newcode2507 src/heap.cc:2507: HandleScope scope; I don't think we need the ...

10 years, 4 months ago (2010-08-11 13:02:09 UTC) #2

Rico

10 years, 4 months ago (2010-08-11 13:14:57 UTC) #3

http://codereview.chromium.org/3146008/diff/1/8
File src/heap.cc (right):

http://codereview.chromium.org/3146008/diff/1/8#newcode2507
src/heap.cc:2507: HandleScope scope;
On 2010/08/11 13:02:09, Kasper Lund wrote:
> I don't think we need the handle scope anymore.

Done.

Expand Messages | Collapse Messages