Issue 3146005: Do not commit buffer in reset function.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3146005: Do not commit buffer in reset function. (Closed)

Created:
10 years, 4 months ago by Peng

Modified:
9 years, 5 months ago

Reviewers:
Zachary Kuznia

CC:
chromium-os-reviews_chromium.org

Base URL:
http://src.chromium.org/git/ibus-chewing.git

Visibility:
Public.

Description

Do not commit buffer in reset function. BUG=chromium-os:4792 TEST=manually

Patch Set 2 : clear ENGINE_STATUS_NEED_COMMIT flag #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -4 lines)			Patch
	M	src/IBusChewingEngine.gob	View	1	1 chunk	+5 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Zachary Kuznia

http://codereview.chromium.org/3146005/diff/1/2 File src/IBusChewingEngine.gob (right): http://codereview.chromium.org/3146005/diff/1/2#newcode943 src/IBusChewingEngine.gob:943: ibus_chewing_engine_clear_status_flag(self, ENGINE_STATUS_FORCE_COMMIT); Should the ENGINE_STATUS_NEED_COMMIT be cleared here, too?

10 years, 4 months ago (2010-08-10 10:52:58 UTC) #2

Peng

On 2010/08/10 10:52:58, Zachary Kuznia wrote: > http://codereview.chromium.org/3146005/diff/1/2 > File src/IBusChewingEngine.gob (right): > > http://codereview.chromium.org/3146005/diff/1/2#newcode943 ...

10 years, 4 months ago (2010-08-11 10:51:05 UTC) #3