Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 3146001: Adding cbuildbot to cros_utils. Leaving old version in repo until buildbot changes over. (Closed)

Created:
10 years, 4 months ago by sosa
Modified:
9 years, 6 months ago
CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, sosa, anush
Base URL:
ssh://git@chromiumos-git//crosutils.git
Visibility:
Public.

Description

Adding cbuildbot to cros_utils. Leaving old version in repo until buildbot changes over. TEST=Ran locally outside of chroot. Required change to remove Exception OSError as e because "as" is a Python 2.6'ism

Patch Set 1 #

Patch Set 2 : Missed config file #

Patch Set 3 : Move to bin #

Patch Set 4 : patch from issue 1499002 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+150 lines, -0 lines) Patch
A bin/cbuildbot View 1 chunk +1 line, -0 lines 0 comments Download
A bin/cbuildbot.py View 3 1 chunk +140 lines, -0 lines 0 comments Download
A bin/cbuildbot_config.py View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
sosa
10 years, 4 months ago (2010-08-09 23:42:35 UTC) #1
anush
Can we put it in the crosutils.git:bin/ directory? The crosutils.ebuild will install the package in ...
10 years, 4 months ago (2010-08-10 00:06:56 UTC) #2
sosa
PTAL. re-tested
10 years, 4 months ago (2010-08-10 00:51:47 UTC) #3
anush
LGTM. On 2010/08/10 00:51:47, sosa wrote: > PTAL. re-tested
10 years, 4 months ago (2010-08-10 01:03:38 UTC) #4
Mandeep Singh Baines
10 years, 4 months ago (2010-08-10 02:11:56 UTC) #5
LGTM after merging in my latest change to cbuildbot.py.

Powered by Google App Engine
This is Rietveld 408576698