Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1532)

Unified Diff: src/trusted/plugin/plugin.cc

Issue 3145013: Fix multi-arch support for Chrome: start downloading the nexe when SetWindow ... (Closed) Base URL: http://nativeclient.googlecode.com/svn/trunk/src/native_client/
Patch Set: '' Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/trusted/plugin/plugin.cc
===================================================================
--- src/trusted/plugin/plugin.cc (revision 2995)
+++ src/trusted/plugin/plugin.cc (working copy)
@@ -379,6 +379,10 @@
// Set up the scriptable methods for the plugin.
LoadMethods();
+// Firefox allows us to call NPN_GetUrl during initialization, so if the "src"
Mark Seaborn 2010/08/16 15:13:59 Actually it's NPN_GetURLNotify(). Can you update
gregoryd 2010/08/16 18:41:09 Done.
+// property has not been specified, we choose a path from the "nexes" list here
+// and start downloading the right nexe immediately.
+#if defined(NACL_STANDALONE)
// If the <embed src='...'> attr was defined, the browser would have
// implicitly called GET on it, which calls Load() and set_logical_url().
// In the absence of this attr, we use the "nexes" attribute if present.
@@ -388,6 +392,7 @@
SetNexesPropertyImpl(nexes_attr);
}
}
+#endif
PLUGIN_PRINTF(("Plugin::Init (return 1)\n"));
// Return success.

Powered by Google App Engine
This is Rietveld 408576698