Fix multi-arch support for Chrome: start downloading the nexe when SetWindow ...

src/trusted/plugin/npapi/plugin_npapi.cc

 /*
  * Copyright 2008 The Native Client Authors. All rights reserved.
  * Use of this source code is governed by a BSD-style license that can
  * be found in the LICENSE file.
  */
 
 
 #include "native_client/src/trusted/plugin/npapi/plugin_npapi.h"
 
 #include <stdio.h>
@@ skipping 152 matching lines @@
 }
 
 // SetWindow is called by the browser as part of the NPAPI interface for
 // setting up a plugin that has the ability to draw into a window.  It is
 // passed a semi-custom window descriptor (some is platform-neutral, some not)
 // as documented in the NPAPI documentation.
 NPError PluginNpapi::SetWindow(NPWindow* window) {
   NPError ret = NPERR_GENERIC_ERROR;
   PLUGIN_PRINTF(("PluginNpapi::SetWindow(%p, %p)\n", static_cast<void* >(this),
                  static_cast<void*>(window)));
+
+// NOTE(gregoryd): Chrome does not allow us to call NPN_GetUrl during
+// initialization, but does call SetWindows afterwards, so we use this call
+// to trigger the download if the src property hasn't been specified.

[Mark Seaborn, 2010/08/16 15:13:59]

Can you link to the Chromium bug here?

[gregoryd, 2010/08/16 18:41:09]

There is no Chromium bug. I spoke to Brett Wilson about it and he suggested that
we change the behavior on our side. It seems that this is yet another issue
where Chrome and Firefox interpret the NPAPI documentation in different ways.

+#if !defined(NACL_STANDALONE)
+  // If the <embed src='...'> attr was defined, the browser would have
+  // implicitly called GET on it, which calls Load() and set_logical_url().
+  // In the absence of this attr, we use the "nexes" attribute if present.
+  if (logical_url() == NULL) {
+    const char* nexes_attr = LookupArgument("nexes");
+    if (nexes_attr != NULL) {
+      SetNexesPropertyImpl(nexes_attr);
+    }
+  }
+#endif
   if (NULL == module_) {
     if (video() && video()->SetWindow(window)) {
         ret = NPERR_NO_ERROR;
     }
     return ret;
   } else {
     // Send NPP_SetWindow to NPModule.
     NPP npp = InstanceIdentifierToNPP(instance_id());
     return module_->SetWindow(npp, window);
   }
@@ skipping 355 matching lines @@
   // It would be nice if the thread interface did not require us to
   // specify a stack size.  This is fairly arbitrary.
   size_t stack_size = 128 << 10;
   NaClThreadCreateJoinable(&plugin->receive_thread_, AsyncReceiveThread, args,
                            stack_size);
   plugin->receive_thread_running_ = true;
   return true;
 }
 
 }  // namespace plugin