chrome/browser/cocoa/menu_controller.mm - Issue 3143046: The "Update Chrome" menu item should appear in addition to the About menu.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/cocoa/menu_controller.mm

Issue 3143046: The "Update Chrome" menu item should appear in addition to the About menu. (Closed) Base URL: http://src.chromium.org/git/chromium.git

Patch Set: estade fixes -> final try Created 10 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/cocoa/menu_controller.mm

diff --git a/chrome/browser/cocoa/menu_controller.mm b/chrome/browser/cocoa/menu_controller.mm

index a5b82568828a3b576b62f36216bdc3ee20ef2b64..4e0aa168129a4d8cba8ce8a8251d68178d381793 100644

--- a/chrome/browser/cocoa/menu_controller.mm

+++ b/chrome/browser/cocoa/menu_controller.mm

@@ -143,6 +143,7 @@

BOOL checked = model->IsItemCheckedAt(modelIndex);

DCHECK([(id)item isKindOfClass:[NSMenuItem class]]);

[(id)item setState:(checked ? NSOnState : NSOffState)];

+ [(id)item setHidden:(!model->IsVisibleAt(modelIndex))];

if (model->IsLabelDynamicAt(modelIndex)) {

NSString* label =

l10n_util::FixUpWindowsStyleLabel(model->GetLabelAt(modelIndex));

« no previous file with comments | « chrome/browser/browser.cc ('k') | chrome/browser/gtk/menu_gtk.h » ('j') | no next file with comments »