app/menus/menu_model.cc - Issue 3143046: The "Update Chrome" menu item should appear in addition to the About menu.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: app/menus/menu_model.cc

Issue 3143046: The "Update Chrome" menu item should appear in addition to the About menu. (Closed) Base URL: http://src.chromium.org/git/chromium.git

Patch Set: estade fixes -> final try Created 10 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: app/menus/menu_model.cc

diff --git a/app/menus/menu_model.cc b/app/menus/menu_model.cc

index 63acbf651c9dc690f6d63d98b35ce342473bfab6..cbce22857a82bc954ccd099990f6f97033474bde 100644

--- a/app/menus/menu_model.cc

+++ b/app/menus/menu_model.cc

@@ -6,6 +6,10 @@

namespace menus {

+bool MenuModel::IsVisibleAt(int index) const {

+ return true;

bool MenuModel::GetModelAndIndexForCommandId(int command_id,

MenuModel** model, int* index) {

int item_count = (*model)->GetItemCount();

« no previous file with comments | « app/menus/menu_model.h ('k') | app/menus/simple_menu_model.h » ('j') | no next file with comments »