Issue 3143035: cros_workon: simplify by symlinking the keywords file to the unmask file

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3143035: cros_workon: simplify by symlinking the keywords file to the unmask file (Closed)

Created:
10 years, 4 months ago by Mandeep Singh Baines

Modified:
9 years, 7 months ago

Reviewers:
zbehan, anush

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, sosa

Base URL:
http://src.chromium.org/git/crosutils.git

Visibility:
Public.

Description

cros_workon: simplify by symlinking the keywords file to the unmask file This is a refactoring change I want to do before I solve the problem of cros_workon list of packages being clobbered by a new setup_board. BUG=5641 TEST=Verified all cases work correctly. 1. Verified that a pre-existing list of workon packages continues to work. 2. Verified that the package.keywords symlink is created correctly. 3. Verified that a new package can be worked on. 4. Verified that an existing package continues to be worked on. Change-Id: I566ac898ac4f74bdd5beb532c1ef0f70d4c02cec pause Change-Id: Ie2d96c897da13292f985d87adfaf3a416a614613

Patch Set 1 #

Patch Set 2 : Fixed #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -14 lines)			Patch
	M	cros_workon	View	1	5 chunks	+13 lines, -14 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

anush

10 years, 4 months ago (2010-08-23 17:49:46 UTC) #3

LGTM.  

On 2010/08/23 15:30:58, Mandeep Singh Baines wrote:
> ping

Expand Messages | Collapse Messages