Issue 3143029: vboot_reference: add in the VbootCrypto tests into vboot_reference git repo

Issue 3143029: vboot_reference: add in the VbootCrypto tests into vboot_reference git repo (Closed)

Created:
10 years, 4 months ago by zbehan

Modified:
9 years, 7 months ago

Reviewers:
Mandeep Singh Baines, ericli, Bill Richardson, Luigi Semenzato, gauravsh, anush, sosa

CC:
chromium-os-reviews_chromium.org, Randall Spangler, gauravsh, Luigi Semenzato, Bill Richardson

Base URL:
http://src.chromium.org/git/vboot_reference.git

Visibility:
Public.

Description

vboot_reference: add in the VbootCrypto tests into vboot_reference git repo Change-Id: I7a46dc2ea475c72703ff5bc1f88fbb021cb24c92

Patch Set 2 : Updated Makefile some, and .py file to reflect parallel make changes into main autotest tree #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+287 lines, -0 lines)			Patch
A	autotest/firmware_VbootCrypto/control	View		1 chunk	+42 lines, -0 lines	0 comments	Download
A	autotest/firmware_VbootCrypto/firmware_VbootCrypto.py	View	1	1 chunk	+190 lines, -0 lines	0 comments	Download
A	autotest/firmware_VbootCrypto/src/Makefile	View	1	1 chunk	+55 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Luigi Semenzato

LGTM On Wed, Aug 18, 2010 at 3:59 PM, <zbehan@chromium.org> wrote: > Reviewers: anush, Mandeep ...

10 years, 4 months ago (2010-08-18 23:04:09 UTC) #2

gauravsh

http://codereview.chromium.org/3143029/diff/1/4 File autotest/firmware_VbootCrypto/src/Makefile (right): http://codereview.chromium.org/3143029/diff/1/4#newcode5 autotest/firmware_VbootCrypto/src/Makefile:5: VBOOT_REFERENCE_DIR = $(GCLIENT_ROOT)/src/platform/vboot_reference shouldn't this be updated too?

10 years, 4 months ago (2010-08-18 23:42:30 UTC) #3

zbehan

Yes it should, and I only really uploaded this change so that people can see ...

10 years, 4 months ago (2010-08-19 00:28:11 UTC) #4

zbehan

10 years, 3 months ago (2010-09-07 20:01:12 UTC) #7

The only issue with the Makefile is that it's acting suicidal when testing,
overwriting itself with another Makefile. I didn't find the time to explore
the build system and changing it to build somewhere else.

Note that for autotest builds, the whole test case directory is taken and
moved somewhere else, so while the Makefile may have a default path fixed to
for example ../../../, it should be possible to override that from
commandline (?=). See the Makefile for src in trousers test.

On Tue, Sep 7, 2010 at 11:04 AM, <gauravsh@chromium.org> wrote:

> LGTM
>
> I will fix the Makefile in a separate CL.
>
>
> http://codereview.chromium.org/3143029/show
>

Expand Messages | Collapse Messages