Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Unified Diff: chrome/browser/resources/options/clear_browser_data_overlay.js

Issue 3143012: Reland r55881: Disable the 'Clear browsing Data' button when no checkboxes are checked. (Closed) Base URL: git://git.chromium.org/chromium.git
Patch Set: address stuart concern Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options/clear_browser_data_overlay.js
diff --git a/chrome/browser/resources/options/clear_browser_data_overlay.js b/chrome/browser/resources/options/clear_browser_data_overlay.js
index 21ae083c4db54b2f180b68a32a8e3914ff3abc19..0542d9a64094d6860296932b3a84758b00be4dfe 100644
--- a/chrome/browser/resources/options/clear_browser_data_overlay.js
+++ b/chrome/browser/resources/options/clear_browser_data_overlay.js
@@ -34,13 +34,44 @@ cr.define('options', function() {
// Setup option values for the time period select control.
$('clearBrowsingDataTimePeriod').initializeValues(
- templateData.clearBrowsingDataTimeList)
+ templateData.clearBrowsingDataTimeList);
+
+ var f = cr.bind(this.updateButtonState_, this);
+ var types = ['browser.clear_data.browsing_history',
+ 'browser.clear_data.download_history',
+ 'browser.clear_data.cache',
+ 'browser.clear_data.cookies',
+ 'browser.clear_data.passwords',
+ 'browser.clear_data.form_data'];
+ types.forEach(function(type) {
+ Preferences.getInstance().addEventListener(type, f);
+ });
+
+ var checkboxes = document.querySelectorAll(
+ '#checkboxListData input[type=checkbox]');
+ for (var i = 0; i < checkboxes.length; i++) {
+ checkboxes[i].onclick = f;
+ }
+ this.updateButtonState_();
// Setup click handler for the clear(Ok) button.
$('clearBrowsingDataCommit').onclick = function(event) {
chrome.send('performClearBrowserData');
};
- }
+ },
+
+ updateButtonState_: function() {
+ var checkboxes = document.querySelectorAll(
+ '#checkboxListData input[type=checkbox]');
+ var isChecked = false;
+ for (var i = 0; i < checkboxes.length; i++) {
+ if (checkboxes[i].checked) {
+ isChecked = true;
+ break;
+ }
+ }
+ $('clearBrowsingDataCommit').disabled = !isChecked;
+ },
};
//

Powered by Google App Engine
This is Rietveld 408576698