Issue 3143: Enable safe browsing tests exercising VerifyMAC. Reorder libraries to match ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3143: Enable safe browsing tests exercising VerifyMAC. Reorder libraries to match ... (Closed)

Created:
12 years, 3 months ago by Dean McNamee

Modified:
9 years, 7 months ago

Reviewers:
Evan Martin

CC:
chromium-reviews_googlegroups.com, please use my chromium address

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Enable safe browsing tests exercising VerifyMAC. Reorder libraries to match the dependency order required on Posix. Patch from Pawel Hajdan Jr. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=2361

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -14 lines)			Patch
M	chrome/SConscript.unit_tests	View	2 chunks	+5 lines, -2 lines	0 comments	Download
M	chrome/browser/safe_browsing/protocol_parser_unittest.cc	View	4 chunks	+0 lines, -7 lines	0 comments	Download
M	chrome/browser/safe_browsing/safe_browsing_util.cc	View	1 chunk	+0 lines, -5 lines	0 comments	Download

Total messages: 3 (0 generated)

Evan Martin

12 years, 3 months ago (2008-09-18 15:46:02 UTC) #3

On 2008/09/18 15:45:33, Evan Martin wrote:
> I'm surprised base depends on net?

Oh, I see, I have it backwards.

LGTM