Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(569)

Unified Diff: sandbox/src/ipc_unittest.cc

Issue 3142022: Sbox IPC fix (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sandbox/src/crosscall_server.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sandbox/src/ipc_unittest.cc
===================================================================
--- sandbox/src/ipc_unittest.cc (revision 56057)
+++ sandbox/src/ipc_unittest.cc (working copy)
@@ -332,6 +332,23 @@
EXPECT_TRUE(NULL == ccp);
}
#endif // defined(NDEBUG)
+
+ ActualCallParams<1, 256> params_3(kTag, 1);
+ params_3.CopyParamIn(0, &value, sizeof(value), false, ULONG_TYPE);
+ buffer = const_cast<void*>(params_3.GetBuffer());
+ EXPECT_TRUE(NULL != buffer);
+
+ size_t correct_size = params_3.OverrideSize(1);
+ ccp = CrossCallParamsEx::CreateFromBuffer(buffer, 256, &out_size);
+ EXPECT_TRUE(NULL == ccp);
+
+ params_3.OverrideSize(correct_size - 4);
+ ccp = CrossCallParamsEx::CreateFromBuffer(buffer, 256, &out_size);
+ EXPECT_TRUE(NULL == ccp);
+
+ params_3.OverrideSize(correct_size);
+ ccp = CrossCallParamsEx::CreateFromBuffer(buffer, 256, &out_size);
+ EXPECT_TRUE(NULL != ccp);
}
// This structure is passed to the mock server threads to simulate
« no previous file with comments | « sandbox/src/crosscall_server.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698