Issue 3142020: Changed ChromeOS status bar menu handlers to obey --enable-tabbed-options swi...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3142020: Changed ChromeOS status bar menu handlers to obey --enable-tabbed-options swi... (Closed)

Created:
10 years, 4 months ago by zel

Modified:
9 years, 6 months ago

Reviewers:
dhg, satorux1

CC:
chromium-reviews, davemoore+watch_chromium.org, ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Changed ChromeOS status bar menu handlers to obey --enable-tabbed-options switch and display the new DOM UI when it's used. BUG=chromium-os:5522 TEST=make sure the new DOM UI option tab opens from status bar drop down menues (language, internet and system settings) Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=56816

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 1

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Patch Set 7 : '' #

Patch Set 8 : '' #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+90 lines, -22 lines)			Patch
M	chrome/app/chrome_dll_resource.h	View	1 2 3 4 5	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/app_controller_mac.mm	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/browser.h	View	1 2 3 4 5 6 7	2 chunks	+4 lines, -2 lines	0 comments	Download
M	chrome/browser/browser.cc	View	1 2 3 4 5 6 7	6 chunks	+50 lines, -9 lines	0 comments	Download
M	chrome/browser/chromeos/frame/browser_view.cc	View	1 2 3 4 5	2 chunks	+1 line, -3 lines	0 comments	Download
M	chrome/browser/gtk/first_run_bubble.cc	View	1 2 3 4 5 6 7	2 chunks	+7 lines, -4 lines	0 comments	Download
M	chrome/browser/options_window.h	View	1 2 3 4 5	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/views/first_run_bubble.cc	View		2 chunks	+2 lines, -3 lines	0 comments	Download
M	chrome/common/url_constants.h	View	1 2 3 4 5 6 7	1 chunk	+11 lines, -0 lines	0 comments	Download
M	chrome/common/url_constants.cc	View	1 2 3 4 5 6 7	1 chunk	+11 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

satorux1

10 years, 4 months ago (2010-08-19 02:10:58 UTC) #3

LGTM. Thank you for doing this!

http://codereview.chromium.org/3142020/diff/17001/18002
File chrome/browser/browser.cc (right):

http://codereview.chromium.org/3142020/diff/17001/18002#newcode1822
chrome/browser/browser.cc:1822:
UserMetrics::RecordAction(UserMetricsAction("ShowOptions"), profile_);
Just FYI. You can get rid of profile_, per user_metrics.h:


  // TODO(semenzato): |profile| isn't actually used---should switch all calls   
  // to the version without it.                                                 
  static void RecordAction(const UserMetricsAction& action, Profile* profile);
  ...
  static void RecordAction(const UserMetricsAction& action);

Expand Messages | Collapse Messages