Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(465)

Issue 3142016: Change EXPECT_ to ASSERT_ for X.509 tests where it will crash if the check fails (Closed)

Created:
10 years, 4 months ago by Ryan Sleevi
Modified:
9 years, 7 months ago
Reviewers:
davidben
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Change EXPECT_ to ASSERT_ for X.509 tests where it will crash if the check fails Some of the X.509 parsing tests rely on a certain number of principals being returned, and will crash otherwise. Change the checks to be ASSERT_, so that the test fails gracefully rather than bringing down net_unittests BUG=none TEST=X509CertificateTest.* Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57004

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M net/base/x509_certificate_unittest.cc View 6 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Ryan Sleevi
David, Would you mind spot checking this for me, as it's nothing major? I ran ...
10 years, 4 months ago (2010-08-18 02:29:56 UTC) #1
davidben
10 years, 4 months ago (2010-08-18 02:42:07 UTC) #2
On 2010/08/18 02:29:56, rsleevi wrote:
> David,
> 
>   Would you mind spot checking this for me, as it's nothing major? I ran into
> this a few times when I was adding the other certificate parsing routines -
and
> while they were bugs in my parsing code, it'd have been much friendlier to
find
> FAILS rather than a full crash.

LGTM.

Powered by Google App Engine
This is Rietveld 408576698