Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/ia32/frames-ia32.cc

Issue 3141047: Cleanup the way the debugger stores live registers when entering at a break... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: '' Created 10 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/debug-ia32.cc ('k') | src/ia32/macro-assembler-ia32.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2008 the V8 project authors. All rights reserved. 1 // Copyright 2006-2008 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
51 51
52 52
53 StackFrame::Type ExitFrame::GetStateForFramePointer(Address fp, State* state) { 53 StackFrame::Type ExitFrame::GetStateForFramePointer(Address fp, State* state) {
54 if (fp == 0) return NONE; 54 if (fp == 0) return NONE;
55 // Compute the stack pointer. 55 // Compute the stack pointer.
56 Address sp = Memory::Address_at(fp + ExitFrameConstants::kSPOffset); 56 Address sp = Memory::Address_at(fp + ExitFrameConstants::kSPOffset);
57 // Fill in the state. 57 // Fill in the state.
58 state->fp = fp; 58 state->fp = fp;
59 state->sp = sp; 59 state->sp = sp;
60 state->pc_address = reinterpret_cast<Address*>(sp - 1 * kPointerSize); 60 state->pc_address = reinterpret_cast<Address*>(sp - 1 * kPointerSize);
61 ASSERT(*state->pc_address != NULL);
61 return EXIT; 62 return EXIT;
62 } 63 }
63 64
64 65
65 void ExitFrame::Iterate(ObjectVisitor* v) const { 66 void ExitFrame::Iterate(ObjectVisitor* v) const {
66 v->VisitPointer(&code_slot()); 67 v->VisitPointer(&code_slot());
67 // The arguments are traversed as part of the expression stack of 68 // The arguments are traversed as part of the expression stack of
68 // the calling frame. 69 // the calling frame.
69 } 70 }
70 71
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
106 Address InternalFrame::GetCallerStackPointer() const { 107 Address InternalFrame::GetCallerStackPointer() const {
107 // Internal frames have no arguments. The stack pointer of the 108 // Internal frames have no arguments. The stack pointer of the
108 // caller is at a fixed offset from the frame pointer. 109 // caller is at a fixed offset from the frame pointer.
109 return fp() + StandardFrameConstants::kCallerSPOffset; 110 return fp() + StandardFrameConstants::kCallerSPOffset;
110 } 111 }
111 112
112 113
113 } } // namespace v8::internal 114 } } // namespace v8::internal
114 115
115 #endif // V8_TARGET_ARCH_IA32 116 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/ia32/debug-ia32.cc ('k') | src/ia32/macro-assembler-ia32.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698