Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1092)

Side by Side Diff: chrome/renderer/render_view_browsertest.cc

Issue 3141040: Disable crashy RenderViewTest.DidFailProvisionalLoadWithErrorForError (Closed)
Patch Set: Created 10 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/basictypes.h" 5 #include "base/basictypes.h"
6 6
7 #include "base/file_util.h" 7 #include "base/file_util.h"
8 #include "base/keyboard_codes.h" 8 #include "base/keyboard_codes.h"
9 #include "base/shared_memory.h" 9 #include "base/shared_memory.h"
10 #include "base/utf_string_conversions.h" 10 #include "base/utf_string_conversions.h"
(...skipping 844 matching lines...) Expand 10 before | Expand all | Expand 10 after
855 const int kMaxOutputCharacters = 4096; 855 const int kMaxOutputCharacters = 4096;
856 std::wstring output = UTF16ToWideHack( 856 std::wstring output = UTF16ToWideHack(
857 GetMainFrame()->contentAsText(kMaxOutputCharacters)); 857 GetMainFrame()->contentAsText(kMaxOutputCharacters));
858 EXPECT_EQ(kLayouts[i].expected_result, output); 858 EXPECT_EQ(kLayouts[i].expected_result, output);
859 } 859 }
860 #else 860 #else
861 NOTIMPLEMENTED(); 861 NOTIMPLEMENTED();
862 #endif 862 #endif
863 } 863 }
864 864
865 TEST_F(RenderViewTest, DidFailProvisionalLoadWithErrorForError) { 865 // Crashy, http://crbug.com/53247.
866 TEST_F(RenderViewTest, DISABLED_DidFailProvisionalLoadWithErrorForError) {
866 GetMainFrame()->enableViewSourceMode(true); 867 GetMainFrame()->enableViewSourceMode(true);
867 WebURLError error; 868 WebURLError error;
868 error.domain.fromUTF8("test_domain"); 869 error.domain.fromUTF8("test_domain");
869 error.reason = net::ERR_FILE_NOT_FOUND; 870 error.reason = net::ERR_FILE_NOT_FOUND;
870 error.unreachableURL = GURL("http://foo"); 871 error.unreachableURL = GURL("http://foo");
871 WebFrame* web_frame = GetMainFrame(); 872 WebFrame* web_frame = GetMainFrame();
872 // An error occurred. 873 // An error occurred.
873 view_->didFailProvisionalLoad(web_frame, error); 874 view_->didFailProvisionalLoad(web_frame, error);
874 // Frame should exit view-source mode. 875 // Frame should exit view-source mode.
875 EXPECT_FALSE(web_frame->isViewSourceModeEnabled()); 876 EXPECT_FALSE(web_frame->isViewSourceModeEnabled());
(...skipping 207 matching lines...) Expand 10 before | Expand all | Expand 10 after
1083 0); 1084 0);
1084 1085
1085 ProcessPendingMessages(); 1086 ProcessPendingMessages();
1086 const IPC::Message* message2 = render_thread_.sink().GetUniqueMessageMatching( 1087 const IPC::Message* message2 = render_thread_.sink().GetUniqueMessageMatching(
1087 ViewHostMsg_FillAutoFillFormData::ID); 1088 ViewHostMsg_FillAutoFillFormData::ID);
1088 1089
1089 // No message should be sent in this case. |firstname| is filled directly. 1090 // No message should be sent in this case. |firstname| is filled directly.
1090 ASSERT_EQ(static_cast<IPC::Message*>(NULL), message2); 1091 ASSERT_EQ(static_cast<IPC::Message*>(NULL), message2);
1091 EXPECT_EQ(firstname.value(), WebKit::WebString::fromUTF8("David")); 1092 EXPECT_EQ(firstname.value(), WebKit::WebString::fromUTF8("David"));
1092 } 1093 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698