Issue 3141035: Fix linux/views build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3141035: Fix linux/views build. (Closed)

Created:
10 years, 4 months ago by Evan Stade

Modified:
9 years, 6 months ago

Reviewers:
Lei Zhang

CC:
chromium-reviews

Base URL:
http://src.chromium.org/git/chromium.git

Visibility:
Public.

Description

Fix linux/views build. BUG=none TEST=compile TBR=thestig Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57111

Patch Set 1 #

Total comments: 2

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	chrome/chrome_browser.gypi	View		1 chunk	+2 lines, -1 line	2 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Lei Zhang

http://codereview.chromium.org/3141035/diff/1/2 File chrome/chrome_browser.gypi (left): http://codereview.chromium.org/3141035/diff/1/2#oldcode3631 chrome/chrome_browser.gypi:3631: ['include', '^browser/gtk/gtk_custom_menu_item.h'], You added gtk_floating_container.*, but remove gtk_custom_menu_item.h. Is ...

10 years, 4 months ago (2010-08-23 22:06:11 UTC) #1

Evan Stade

10 years, 4 months ago (2010-08-23 23:49:57 UTC) #2

http://codereview.chromium.org/3141035/diff/1/2
File chrome/chrome_browser.gypi (left):

http://codereview.chromium.org/3141035/diff/1/2#oldcode3631
chrome/chrome_browser.gypi:3631: ['include',
'^browser/gtk/gtk_custom_menu_item.h'],
On 2010/08/23 22:06:11, Lei Zhang wrote:
> You added gtk_floating_container.*, but remove gtk_custom_menu_item.h. Is that
> right?

no, it's not right. Luckily the .hs don't actually matter unless you're using an
IDE. I will fix this.

Expand Messages | Collapse Messages