Issue 3141034: Move the function name inferrer code from the AstOptimizer to...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3141034: Move the function name inferrer code from the AstOptimizer to... (Closed)

Created:
10 years, 4 months ago by Kasper Lund

Modified:
9 years, 7 months ago

Reviewers:
mnaganov (inactive), Rico

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Move the function name inferrer code from the AstOptimizer to the parser in preparation for not using the optimizer when using the full codegen. Code covered by existing tests. Committed: http://code.google.com/p/v8/source/detail?r=5321

Patch Set 1 #

Total comments: 3

Patch Set 2 : '' #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+80 lines, -77 lines)			Patch
M	src/func-name-inferrer.h	View		4 chunks	+15 lines, -39 lines	0 comments	Download
M	src/func-name-inferrer.cc	View		1 chunk	+14 lines, -0 lines	0 comments	Download
M	src/parser.cc	View	1	20 chunks	+50 lines, -1 line	0 comments	Download
M	src/rewriter.cc	View	1	10 chunks	+1 line, -37 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

mnaganov (inactive)

http://codereview.chromium.org/3141034/diff/1/4 File src/parser.cc (right): http://codereview.chromium.org/3141034/diff/1/4#newcode2874 src/parser.cc:2874: if ((op == Token::INIT_VAR Drive-by comment: maybe add an ...

10 years, 4 months ago (2010-08-23 13:17:18 UTC) #3

Rico

LGTM http://codereview.chromium.org/3141034/diff/1/5 File src/rewriter.cc (right): http://codereview.chromium.org/3141034/diff/1/5#newcode31 src/rewriter.cc:31: #include "func-name-inferrer.h" Do we still need this include?

10 years, 4 months ago (2010-08-23 13:19:23 UTC) #4

Kasper Lund

10 years, 4 months ago (2010-08-23 13:25:14 UTC) #5

http://codereview.chromium.org/3141034/diff/1/5
File src/rewriter.cc (right):

http://codereview.chromium.org/3141034/diff/1/5#newcode31
src/rewriter.cc:31: #include "func-name-inferrer.h"
On 2010/08/23 13:19:23, Rico wrote:
> Do we still need this include?

No. Removed.

Expand Messages | Collapse Messages