Issue 3141033: Remove wstrings from bookmarks, part 13.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3141033: Remove wstrings from bookmarks, part 13. (Closed)

Created:
10 years, 4 months ago by viettrungluu

Modified:
9 years, 6 months ago

Reviewers:
Miranda Callahan

CC:
chromium-reviews, Paweł Hajdan Jr., ben+cc_chromium.org, John Grabowski, pam+watch_chromium.org

Visibility:
Public.

Description

Remove wstrings from bookmarks, part 13. This eliminates wstrings from bookmark_model_unittest.cc, which entails removing them from model_test_utils.*. BUG=23581 TEST=builds and passes tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57292

Patch Set 1 #

Patch Set 2 : oops #

Patch Set 3 : argh #

Patch Set 4 : macoops #

Patch Set 5 : sigh #

Patch Set 6 : macoops2 #

Patch Set 7 : macoops3 #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+130 lines, -127 lines)			Patch
M	chrome/browser/bookmarks/bookmark_model_test_utils.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/bookmarks/bookmark_model_unittest.cc	View	1 2 3 4	7 chunks	+26 lines, -26 lines	0 comments	Download
M	chrome/browser/cocoa/applescript/bookmark_applescript_utils_unittest.mm	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/cocoa/bookmark_bar_controller_unittest.mm	View		11 chunks	+24 lines, -24 lines	0 comments	Download
M	chrome/browser/cocoa/bookmark_bar_folder_controller_unittest.mm	View		24 chunks	+49 lines, -49 lines	0 comments	Download
M	chrome/test/model_test_utils.h	View		2 chunks	+5 lines, -2 lines	0 comments	Download
M	chrome/test/model_test_utils.cc	View	1	3 chunks	+23 lines, -23 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Miranda Callahan

To get your answer, unscramble the letters in this jumble: GMTL

10 years, 4 months ago (2010-08-25 04:29:57 UTC) #3

viettrungluu

10 years, 4 months ago (2010-08-25 06:39:28 UTC) #4

On 2010/08/25 04:29:57, Miranda Callahan wrote:
> To get your answer, unscramble the letters in this jumble:
> GMTL

>>> import itertools
>>> [''.join(x) for x in itertools.permutations('GMTL')]
['GMTL', 'GMLT', 'GTML', 'GTLM', 'GLMT', 'GLTM', 'MGTL', 'MGLT', 'MTGL', 'MTLG',
'MLGT', 'MLTG', 'TGML', 'TGLM', 'TMGL', 'TMLG', 'TLGM', 'TLMG', 'LGMT', 'LGTM',
'LMGT', 'LMTG', 'LTGM', 'LTMG']

So many to choose from. I kind of like TLMG though.

Expand Messages | Collapse Messages