Chromium Code Reviews Chromium Code Reviews
Issue
3141031:
[Chrome OS] Wire up ownership API from libcros (Closed)
Description[Chrome OS] Wire up ownership API from libcros
I added an asynchronous API to libcros for setting the Owner's key
on Chrome OS. This CL wires that out through LoginLibrary and also
refactors the OwnerManager class into the OwnershipService, a
Singleton that will provide access to the entire Ownership API --
which includes methods for whitelisting users and signed preferences.
The OwnerManager class is now just there to manage the Owner's
key and operations with that key.
A consumer of this API can call methods of OwnershipService, which will post tasks to run methods from OwnerManager (on the FILE thread if appropriate). The OwnerManager will, in turn, call methods of LoginLibrary to perform owner key operations. Since these calls to LoginLibrary are asyncrhonous, OwnerManager implements LoginLibrary::Delegate and passes |this|, so that LoginLibrary can call back to the OwnerManager when asynchronous operations are completed.
BUG=chromium-os:4488
TEST=unit tests
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57269
Patch Set 1 #Patch Set 2 : Remove dead code, fix browser_tests compile #Patch Set 3 : Header guard #Patch Set 4 : remove reference to dead header #
Total comments: 6
Patch Set 5 : phajdan comments #
Total comments: 8
Patch Set 6 : address davemoore comments #Messages
Total messages: 9 (0 generated)
|
