third_party/tlslite/patches/send_certificate_types.patch - Issue 3141026: Reintegrate certificate selection in HttpNetworkTransaction DoLoop

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/tlslite/patches/send_certificate_types.patch

Issue 3141026: Reintegrate certificate selection in HttpNetworkTransaction DoLoop (Closed)

Patch Set: Address Wan-Teh's comments and rebase on top of trunk Created 10 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 diff --git a/tlslite/constants.py b/tlslite/constants.py

	2 index 8f2d559..04302c0 100644

	3 --- a/tlslite/constants.py

	4 +++ b/tlslite/constants.py

	5 @@ -5,6 +5,12 @@ class CertificateType:

	6 openpgp = 1

	7 cryptoID = 2

	8

	9 +class ClientCertificateType:

	10 + rsa_sign = 1

	11 + dss_sign = 2

	12 + rsa_fixed_dh = 3

	13 + dss_fixed_dh = 4

	14 +

	15 class HandshakeType:

	16 hello_request = 0

	17 client_hello = 1

	18 diff --git a/tlslite/messages.py b/tlslite/messages.py

	19 index 06c46b9..8bcec2c 100644

	20 --- a/tlslite/messages.py

	21 +++ b/tlslite/messages.py

	22 @@ -346,7 +346,9 @@ class Certificate(HandshakeMsg):

	23 class CertificateRequest(HandshakeMsg):

	24 def __init__(self):

	25 self.contentType = ContentType.handshake

	26 - self.certificate_types = []

	27 + #Apple's implementation rejects empty certificate_types, so

	28 + #default to rsa_sign.

	29 + self.certificate_types = [ClientCertificateType.rsa_sign]

	30 #treat as opaque bytes for now

	31 self.certificate_authorities = createByteArraySequence([])

	32

OLD	NEW

« no previous file with comments | « third_party/tlslite/README.chromium ('k') | third_party/tlslite/tlslite/constants.py » ('j') | no next file with comments »